fix(skills): align PR repair and push gates

[cv]

Summary

Follows PR #8597 by aligning the shared PR repair loop with the contributor PR push gate. The workflow now removes retained review evidence after classification and prevents a push while any unresolved finding requires a change.

Changes

• Remove retained review evidence after classification and verify that the artifact is absent.
• Define a user-deferred non-blocking suggestion as not requiring a change in the current review cycle.
• Split repair, validation, commit, documentation review, and collection into separate instructions.
• Use the same unresolved-finding push rule in the shared follow-up workflow and contributor PR skill.
• Update the policy test to reject the obsolete push criterion.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Docs updated for user-facing behavior changes
• Docs not applicable — justification: This changes internal contributor-agent workflow guidance. It does not change a public command, configuration, or runtime behavior.
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

• Documentation writer subagent reviewed the completed changes
• Result: docs-updated
• Evidence: Reviewed terminology, structure, voice, procedures, support claims, and policy-test coverage. Changed documentation paths: .agents/skills/_shared/pr-follow-up.md and .agents/skills/nemoclaw-contributor-create-pr/SKILL.md. No public Fern page or agent-variant update is required.
• Agent: Pi CLI

DGX Station Hardware Evidence

• Tested on DGX Station
• Tested commit:
• Station profile/scenario:
• Result:
• Supporting evidence:

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run --project integration test/maintainer-skills-policy.test.ts — 23 tests passed; npm run docs passed with zero errors and two Fern warnings; npm run validate:pr passed on the committed diff.
• Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

• Documentation
  • Clarified pull request review procedures, including classification and tracking of findings.
  • Added explicit requirements for resolving, validating, and re-reviewing changes before pushing.
  • Documented handling for retained evidence, deferred suggestions, stop requests, and missing review artifacts.
• Tests
  • Updated policy checks to verify final review completion and prevent pushes when unresolved or unclassified findings remain.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 49212666-b0f7-4aa9-ad8c-a531666415e8

📥 Commits

Reviewing files that changed from the base of the PR and between 4a33152 and bceca79.

📒 Files selected for processing (2)

• .agents/skills/nemoclaw-contributor-create-pr/SKILL.md
• test/maintainer-skills-policy.test.ts

🚧 Files skipped from review as they are similar to previous changes (2)

• test/maintainer-skills-policy.test.ts
• .agents/skills/nemoclaw-contributor-create-pr/SKILL.md

---

📝 Walkthrough

Walkthrough

The PR updates contributor review workflows and maintainer policy tests. The changes require final review collection, matching reviewed HEAD values, evidence cleanup, finding classification, validated repairs, and explicit handling of deferred suggestions.

Changes

Review-cycle gating

Layer / File(s)	Summary
Review-cycle and push-gate procedures .agents/skills/_shared/pr-follow-up.md, .agents/skills/nemoclaw-contributor-create-pr/SKILL.md	The workflows classify findings, remove retained evidence, validate required repairs, recollect reviews, and verify matching final headRefOid values before pushing.
Policy test coverage test/maintainer-skills-policy.test.ts	Tests require the final review cycle and verify evidence removal, deferred non-blocking suggestions, unclassified findings, and unresolved required changes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• NVIDIA/NemoClaw#8533: Refines the review-cycle and push-gate procedures and tests in the same files.
• NVIDIA/NemoClaw#8545: Modifies the contributor skill and related policy tests for review-feedback handling.
• NVIDIA/NemoClaw#8575: Modifies the review-cycle and push-gate workflow, including finding classification and evidence handling.

Suggested labels: area: skills, bug-fix

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main changes to PR repair and push gates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/pr-review-repair-loop-follow-up

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit bceca79 in the codex/pr-review-repa... branch remains at 96%, unchanged from commit fad771a in the main branch.

---

_{Updated August 08, 2026 15:43 UTC}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.agents/skills/nemoclaw-contributor-create-pr/SKILL.md:
- Around line 67-77: The push gate must consistently block every unresolved
finding that requires a change, not only findings labeled blocking. In
.agents/skills/nemoclaw-contributor-create-pr/SKILL.md lines 67-77, update the
adjacent push summary to use that exact condition (or define “blocking finding”
as equivalent); in test/maintainer-skills-policy.test.ts lines 679-690, add a
negative assertion rejecting the narrower blocking-only wording.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 498ea0d6-f96a-403b-a967-0c9b8aa7e408

📥 Commits

Reviewing files that changed from the base of the PR and between ebbbc91 and 4a33152.

📒 Files selected for processing (3)

• .agents/skills/_shared/pr-follow-up.md
• .agents/skills/nemoclaw-contributor-create-pr/SKILL.md
• test/maintainer-skills-policy.test.ts

[github-actions]

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Failed after a partial review · low confidence · 0 blockers · 0 warnings · 0 suggestions

Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests.

2 semantic terminology decisions

Terminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.

• define — unresolved finding at .agents/skills/_shared/pr-follow-up.md:140: Define this term when first used, or state its repair and deferral conditions in the push-gate instruction.
• justified — requires a change at .agents/skills/_shared/pr-follow-up.md:141: Keep this modifier with the stated deferral contrast in each push-gate instruction.

E2E guidance

Advisory only. A maintainer can dispatch the default E2E suite against this exact revision.

Recommended E2E: None

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.