Skip to content

chore(deps): update LangChain Deep Agents Code to 0.1.54 - #8620

Draft
prekshivyas wants to merge 2 commits into
NVIDIA:mainfrom
prekshivyas:patch-walker/langchain-deep-agents-code-0.1.54-401c6b2528
Draft

chore(deps): update LangChain Deep Agents Code to 0.1.54#8620
prekshivyas wants to merge 2 commits into
NVIDIA:mainfrom
prekshivyas:patch-walker/langchain-deep-agents-code-0.1.54-401c6b2528

Conversation

@prekshivyas

Copy link
Copy Markdown
Collaborator

Summary

Updates LangChain Deep Agents Code from 0.1.34 to 0.1.54 using the sealed NemoPin migration evidence. This PR remains draft for human review.

Related Issue

No issue closure is claimed by this draft.

Changes

  • Applies only paths authorized by sha256:401c6b25284280b8da7158afba26762cef533a4650b99f06c212c8e9abc6e4c5.
  • Migrates the exact base 0ded771c33c01b8df82239945c0b84bbdcaad77e across 20 adjacent release ranges.
  • Changed paths: agents/langchain-deepagents-code/Dockerfile.base, agents/langchain-deepagents-code/dcode-wrapper.sh, agents/langchain-deepagents-code/dependency-review.md, agents/langchain-deepagents-code/manifest.yaml, agents/langchain-deepagents-code/patch-managed-deepagents-code.py, agents/langchain-deepagents-code/profile-plugin/pyproject.toml, agents/langchain-deepagents-code/profile-plugin/src/nemoclaw_deepagents_profile/__init__.py, agents/langchain-deepagents-code/requirements.in, agents/langchain-deepagents-code/requirements.lock, agents/langchain-deepagents-code/start.sh, agents/langchain-deepagents-code/validate-nemotron-ultra-profile.py, agents/langchain-deepagents-code/validate-progressive-tool-disclosure.py, src/lib/actions/sandbox/rebuild-flow-helpers.test.ts, src/lib/agent/base-image.test.ts, src/lib/agent/deep-agents-code-base-image.test.ts, src/lib/agent/onboard-terminal-fixtures.test.ts, src/lib/agent/onboard-terminal-fixtures.ts, src/lib/agent/onboard-terminal.test.ts, src/lib/sandbox-base-image-agent-resolution.test.ts, src/lib/sandbox-base-image-release-resolution.test.ts, src/lib/sandbox-base-image/resolution-key.test.ts, test/Dockerfile.dcode-profile-missing-dependencies, test/cli/connect-terminal-agent.test.ts, test/deepagents-code-tui-startup-check.test.ts, test/e2e/e2e-cloud-experimental/checks/03-deepagents-code-nemotron-ultra-profile.sh, test/e2e/e2e-cloud-experimental/checks/10-deepagents-code-tui-startup.sh, test/helpers/langchain-deepagents-code-patch-fixture.ts, test/issue-5667-hosted-inference-model-namespace.test.ts, test/langchain-deepagents-code-direct-module-patch.test.ts, test/langchain-deepagents-code-image.test.ts, test/langchain-deepagents-code-nemotron-profile-plugin.test.ts, test/langchain-deepagents-code-progressive-tool-disclosure.test.ts

Release ranges

Range Commits State Concerns
0.1.34 → 0.1.35 bd9bafaad3f509daab5772ff published 3
0.1.35 → 0.1.36 09daab5772ff2f56309d821d published 3
0.1.36 → 0.1.37 2f56309d821ddef6369aed1a published 4
0.1.37 → 0.1.38 def6369aed1a4338671aa1d9 published 2
0.1.38 → 0.1.39 4338671aa1d98eb909a59b82 published 6
0.1.39 → 0.1.40 8eb909a59b82019489edb9c0 published 4
0.1.40 → 0.1.41 019489edb9c0d46a2cb033b8 published 3
0.1.41 → 0.1.42 d46a2cb033b818679a1a88a3 published 2
0.1.42 → 0.1.43 18679a1a88a3e14e0adcbe78 published 5
0.1.43 → 0.1.44 e14e0adcbe782b9cd08f0492 published 4
0.1.44 → 0.1.45 2b9cd08f04927794b61a6e76 published 1
0.1.45 → 0.1.46 7794b61a6e76efa86c51fedd published 3
0.1.46 → 0.1.47 efa86c51fedd8aa29ddc2833 published 3
0.1.47 → 0.1.48 8aa29ddc2833803b8329db7d published 0
0.1.48 → 0.1.49 803b8329db7d44910bc2ef3f published 2
0.1.49 → 0.1.50 44910bc2ef3f63adb9645687 published 0
0.1.50 → 0.1.51 63adb9645687d2b663fca277 published 3
0.1.51 → 0.1.52 d2b663fca277b428644d31dd published 3
0.1.52 → 0.1.53 b428644d31dd0bd15dc0e1c5 published 0
0.1.53 → 0.1.54 0bd15dc0e1c581258067f4c7 published 5

Concern dispositions

Concern Surface Planned disposition Failure prevented Remaining gate
langchain-deep-agents-code-0.1.34..0.1.35-compatibility-change-1 compatibility change test 0.1.54 reports compatibility change: ### Features - Added Meta muse-spark-1.2 to the model switcher (#5389). - Improv... none
langchain-deep-agents-code-0.1.34..0.1.35-execution-control-2 execution control guard 0.1.54 reports execution control: ### Features - Added Meta muse-spark-1.2 to the model switcher (#5389). - Improved ... none
langchain-deep-agents-code-0.1.34..0.1.35-lifecycle-state-3 lifecycle state test 0.1.54 reports lifecycle state: ### Features - Added Meta muse-spark-1.2 to the model switcher (#5389). - Improved di... none
langchain-deep-agents-code-0.1.35..0.1.36-compatibility-change-1 compatibility change test 0.1.53 reports compatibility change: ### Features - Added pricing coverage with Baseten built-in overrides and local fallback overrides when genai-prices is missing data ([#53... none
langchain-deep-agents-code-0.1.35..0.1.36-lifecycle-state-2 lifecycle state test 0.1.53 reports lifecycle state: ### Features - Added pricing coverage with Baseten built-in overrides and local fallback overrides when genai-prices is missing data ([#5312](h... none
langchain-deep-agents-code-0.1.35..0.1.36-runtime-topology-3 runtime topology test 0.1.53 reports runtime topology: ### Features - Added pricing coverage with Baseten built-in overrides and local fallback overrides when genai-prices is missing data ([#5312](... none
langchain-deep-agents-code-0.1.36..0.1.37-compatibility-change-1 compatibility change test 0.1.52 reports compatibility change: ### Features - Hooks v2 is now generally available, with support for loading hooks from installed plugins. ([#5307](https://github.com/langc... none
langchain-deep-agents-code-0.1.36..0.1.37-configuration-2 configuration test 0.1.52 reports configuration: ### Features - Hooks v2 is now generally available, with support for loading hooks from installed plugins. ([#5307](https://github.com/langchain-ai... none
langchain-deep-agents-code-0.1.36..0.1.37-execution-control-3 execution control guard 0.1.52 reports execution control: ### Features - Hooks v2 is now generally available, with support for loading hooks from installed plugins. ([#5307](https://github.com/langchai... none
langchain-deep-agents-code-0.1.36..0.1.37-lifecycle-state-4 lifecycle state test 0.1.52 reports lifecycle state: ### Features - Hooks v2 is now generally available, with support for loading hooks from installed plugins. ([#5307](https://github.com/langchain-... none
langchain-deep-agents-code-0.1.37..0.1.38-compatibility-change-1 compatibility change test 0.1.51 reports compatibility change: ### Features - The status bar and usage view now show the running session cost. ([#5036](langchain-ai/deepagents#5... none
langchain-deep-agents-code-0.1.37..0.1.38-configuration-2 configuration test 0.1.51 reports configuration: ### Features - The status bar and usage view now show the running session cost. (#5036) -... none
langchain-deep-agents-code-0.1.38..0.1.39-compatibility-change-1 compatibility change test 0.1.50 reports compatibility change: ### Highlights - Added project hooks workspace trust and expanded Hooks v2 support with client and server lifecycle events plus runtime feed... none
langchain-deep-agents-code-0.1.38..0.1.39-execution-control-2 execution control guard 0.1.50 reports execution control: ### Highlights - Added project hooks workspace trust and expanded Hooks v2 support with client and server lifecycle events plus runtime feedbac... none
langchain-deep-agents-code-0.1.38..0.1.39-lifecycle-state-3 lifecycle state test 0.1.50 reports lifecycle state: ### Highlights - Added project hooks workspace trust and expanded Hooks v2 support with client and server lifecycle events plus runtime feedback ... none
langchain-deep-agents-code-0.1.38..0.1.39-packaging-artifact-4 packaging artifact test 0.1.50 reports packaging artifact: ### Highlights - Added project hooks workspace trust and expanded Hooks v2 support with client and server lifecycle events plus runtime feedba... none
langchain-deep-agents-code-0.1.38..0.1.39-runtime-topology-5 runtime topology test 0.1.50 reports runtime topology: ### Highlights - Added project hooks workspace trust and expanded Hooks v2 support with client and server lifecycle events plus runtime feedback... none
langchain-deep-agents-code-0.1.38..0.1.39-security-identity-6 security identity guard 0.1.50 reports security identity: ### Highlights - Added project hooks workspace trust and expanded Hooks v2 support with client and server lifecycle events plus runtime feedbac... none
langchain-deep-agents-code-0.1.39..0.1.40-compatibility-change-1 compatibility change test 0.1.49 reports compatibility change: ### Features - Added recognition for LangSmith Gateway credentials. (#5042) - Adde... none
langchain-deep-agents-code-0.1.39..0.1.40-execution-control-2 execution control guard 0.1.49 reports execution control: ### Features - Added recognition for LangSmith Gateway credentials. (#5042) - Added s... none
langchain-deep-agents-code-0.1.39..0.1.40-lifecycle-state-3 lifecycle state test 0.1.49 reports lifecycle state: ### Features - Added recognition for LangSmith Gateway credentials. (#5042) - Added sla... none
langchain-deep-agents-code-0.1.39..0.1.40-runtime-topology-4 runtime topology test 0.1.49 reports runtime topology: ### Features - Added recognition for LangSmith Gateway credentials. (#5042) - Added sl... none
langchain-deep-agents-code-0.1.40..0.1.41-compatibility-change-1 compatibility change test 0.1.48 reports compatibility change: ### Features - Added Fireworks kimi-k3, GLM-5.2-Fast, and Kimi-K3 to model selection and recommended models. ([#5082](https://github.com/l... none
langchain-deep-agents-code-0.1.40..0.1.41-execution-control-2 execution control guard 0.1.48 reports execution control: ### Features - Added Fireworks kimi-k3, GLM-5.2-Fast, and Kimi-K3 to model selection and recommended models. ([#5082](https://github.com/lang... none
langchain-deep-agents-code-0.1.40..0.1.41-lifecycle-state-3 lifecycle state test 0.1.48 reports lifecycle state: ### Features - Added Fireworks kimi-k3, GLM-5.2-Fast, and Kimi-K3 to model selection and recommended models. ([#5082](https://github.com/langch... none
langchain-deep-agents-code-0.1.41..0.1.42-compatibility-change-1 compatibility change test 0.1.47 reports compatibility change: ### Features - Added yolo mode to the Shift+Tab approval cycle (#5035). - Show... none
langchain-deep-agents-code-0.1.41..0.1.42-execution-control-2 execution control guard 0.1.47 reports execution control: ### Features - Added yolo mode to the Shift+Tab approval cycle (#5035). - Show th... none
langchain-deep-agents-code-0.1.42..0.1.43-compatibility-change-1 compatibility change test 0.1.46 reports compatibility change: ### Highlights - Auto mode is now generally available. #4957 - Added configurable ... none
langchain-deep-agents-code-0.1.42..0.1.43-configuration-2 configuration test 0.1.46 reports configuration: ### Highlights - Auto mode is now generally available. #4957 - Added configurable Auto go... none
langchain-deep-agents-code-0.1.42..0.1.43-execution-control-3 execution control guard 0.1.46 reports execution control: ### Highlights - Auto mode is now generally available. #4957 - Added configurable Aut... none
langchain-deep-agents-code-0.1.42..0.1.43-protocol-schema-4 protocol schema test 0.1.46 reports protocol schema: ### Highlights - Auto mode is now generally available. #4957 - Added configurable Auto ... none
langchain-deep-agents-code-0.1.42..0.1.43-security-identity-5 security identity guard 0.1.46 reports security identity: ### Highlights - Auto mode is now generally available. #4957 - Added configurable Aut... none
langchain-deep-agents-code-0.1.43..0.1.44-compatibility-change-1 compatibility change test 0.1.45 reports compatibility change: ### Features - Added the Hooks v2 execution engine and typed hooks data models ([#4880](langchain-ai/deepagents#48... none
langchain-deep-agents-code-0.1.43..0.1.44-execution-control-2 execution control guard 0.1.45 reports execution control: ### Features - Added the Hooks v2 execution engine and typed hooks data models (#4880... none
langchain-deep-agents-code-0.1.43..0.1.44-lifecycle-state-3 lifecycle state test 0.1.45 reports lifecycle state: ### Features - Added the Hooks v2 execution engine and typed hooks data models (#4880, ... none
langchain-deep-agents-code-0.1.43..0.1.44-packaging-artifact-4 packaging artifact test 0.1.45 reports packaging artifact: ### Features - Added the Hooks v2 execution engine and typed hooks data models ([#4880](langchain-ai/deepagents#4880... none
langchain-deep-agents-code-0.1.44..0.1.45-runtime-topology-1 runtime topology test 0.1.44 reports runtime topology: ### Bug Fixes - Improved approval handling by hiding the Auto option when it isn't eligible and moving Auto mode path checks off the event loo... none
langchain-deep-agents-code-0.1.45..0.1.46-compatibility-change-1 compatibility change test 0.1.43 reports compatibility change: ### Features - Added classifier-backed Auto approval mode behind DEEPAGENTS_CODE_EXPERIMENTAL=1 ([#4804](https://github.com/langchain-ai/d... none
langchain-deep-agents-code-0.1.45..0.1.46-execution-control-2 execution control guard 0.1.43 reports execution control: ### Features - Added classifier-backed Auto approval mode behind DEEPAGENTS_CODE_EXPERIMENTAL=1 ([#4804](https://github.com/langchain-ai/deep... none
langchain-deep-agents-code-0.1.45..0.1.46-lifecycle-state-3 lifecycle state test 0.1.43 reports lifecycle state: ### Features - Added classifier-backed Auto approval mode behind DEEPAGENTS_CODE_EXPERIMENTAL=1 ([#4804](https://github.com/langchain-ai/deepag... none
langchain-deep-agents-code-0.1.46..0.1.47-compatibility-change-1 compatibility change test 0.1.42 reports compatibility change: ### Features - Plugins are now generally available. (#4797) - Added search to the ... none
langchain-deep-agents-code-0.1.46..0.1.47-execution-control-2 execution control guard 0.1.42 reports execution control: ### Features - Plugins are now generally available. (#4797) - Added search to the plu... none
langchain-deep-agents-code-0.1.46..0.1.47-lifecycle-state-3 lifecycle state test 0.1.42 reports lifecycle state: ### Features - Plugins are now generally available. (#4797) - Added search to the plugi... none
langchain-deep-agents-code-0.1.48..0.1.49-compatibility-change-1 compatibility change test 0.1.40 reports compatibility change: ### Features - Added plugin marketplace support (#4554). - Added an “always allow”... none
langchain-deep-agents-code-0.1.48..0.1.49-execution-control-2 execution control guard 0.1.40 reports execution control: ### Features - Added plugin marketplace support (#4554). - Added an “always allow” op... none
langchain-deep-agents-code-0.1.50..0.1.51-compatibility-change-1 compatibility change test 0.1.38 reports compatibility change: ### Features * Improve /goal criteria UX (#4694) ([06f46ff](https://github.com/l... none
langchain-deep-agents-code-0.1.50..0.1.51-configuration-2 configuration test 0.1.38 reports configuration: ### Features * Improve /goal criteria UX (#4694) ([06f46ff](https://github.com/langchai... none
langchain-deep-agents-code-0.1.50..0.1.51-lifecycle-state-3 lifecycle state test 0.1.38 reports lifecycle state: ### Features * Improve /goal criteria UX (#4694) ([06f46ff](https://github.com/langch... none
langchain-deep-agents-code-0.1.51..0.1.52-compatibility-change-1 compatibility change test 0.1.37 reports compatibility change: ### Features * Add Meta model provider (#4650) ([70829c5](https://github.com/langc... none
langchain-deep-agents-code-0.1.51..0.1.52-configuration-2 configuration test 0.1.37 reports configuration: ### Features * Add Meta model provider (#4650) ([70829c5](https://github.com/langchain-ai... none
langchain-deep-agents-code-0.1.51..0.1.52-security-identity-3 security identity guard 0.1.37 reports security identity: ### Features * Add Meta model provider (#4650) ([70829c5](https://github.com/langchai... none
langchain-deep-agents-code-0.1.53..0.1.54-compatibility-change-1 compatibility change test 0.1.35 reports compatibility change: ### Features * Restore interrupted prompt to input on ESC (#4544) ([fccf037](https... none
langchain-deep-agents-code-0.1.53..0.1.54-configuration-2 configuration test 0.1.35 reports configuration: ### Features * Restore interrupted prompt to input on ESC (#4544) ([fccf037](https://gith... none
langchain-deep-agents-code-0.1.53..0.1.54-execution-control-3 execution control guard 0.1.35 reports execution control: ### Features * Restore interrupted prompt to input on ESC (#4544) ([fccf037](https://... none
langchain-deep-agents-code-0.1.53..0.1.54-lifecycle-state-4 lifecycle state test 0.1.35 reports lifecycle state: ### Features * Restore interrupted prompt to input on ESC (#4544) ([fccf037](https://gi... none
langchain-deep-agents-code-0.1.53..0.1.54-protocol-schema-5 protocol schema test 0.1.35 reports protocol schema: ### Features * Restore interrupted prompt to input on ESC (#4544) ([fccf037](https://gi... none

Immutable artifacts

Artifact SHA-256
deepagents_code-0.1.54-py3-none-any.whl fbfd0fc31caf5a8b…
deepagents_code-0.1.54.tar.gz 74df86f91a11d5db…

Validation receipt

Gate Current result
targeted Pending on this exact draft head
full-e2e Pending on this exact draft head

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification: No user-facing documentation update is required. The patch upgrades the internal, hash-locked Deep Agents Code dependency from 0.1.34 to 0.1.54 while preserving NemoClaw’s existing managed approval, credential, update, startup, and policy behavior. The changed dependency-review.md records internal supply-chain evidence.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

  • Documentation writer subagent reviewed the completed changes
  • Result: no-docs-needed
  • Evidence: No user-facing documentation update is required. The patch upgrades the internal, hash-locked Deep Agents Code dependency from 0.1.34 to 0.1.54 while preserving NemoClaw’s existing managed approval, credential, update, startup, and policy behavior. The changed dependency-review.md records internal supply-chain evidence.
  • Agent: NemoPatch documentation reviewer (OpenClaw in OpenShell)

DGX Station Hardware Evidence

  • Tested on DGX Station
  • Tested commit:
  • Station profile/scenario:
  • Result:
  • Supporting evidence:

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification:
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Prekshi Vyas prekshiv@nvidia.com

Patch-Walker-Manifest: sha256:401c6b25284280b8da7158afba26762cef533a4650b99f06c212c8e9abc6e4c5

Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 8, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ae08b36e-5338-4fa0-9895-921b72e44f1c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — Blocking findings reported

Advisor assessment: Blockers require maintainer review
Next action: Review the blockers below.
Findings: 1 blocker · 1 warning · 0 suggestions
Status: Partial review preserved 2 canonical finding(s) and 3 terminology decision(s) before the advisor stopped.

Model lanes

  • GPT-5.6 Terra (primary): Failed after a partial review · low confidence · 1 blocker · 1 warning · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Failed after a partial review · low confidence · 0 blockers · 2 warnings · 0 suggestions

Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests.

3 semantic terminology decisions

Terminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.

  • established — approval mode at agents/langchain-deepagents-code/patch-managed-deepagents-code.py:171: Keep "approval mode" for the upstream persisted setting. Keep "auto-approval mode" for NemoClaw's attested capability.
  • define — startup mode at agents/langchain-deepagents-code/dependency-review.md:26: Define startup mode at first use as the persisted Deep Agents Code setting that selects startup behavior.
  • established — managed session at agents/langchain-deepagents-code/patch-managed-deepagents-code.py:171: Keep "managed session" where the surrounding sentence identifies the NemoClaw-managed context.

E2E guidance

Advisory only. A maintainer can dispatch the default E2E suite against this exact revision.

Recommended E2E: cloud-inference, cloud-onboard, managed-image-multiarch-startup, security-posture, full-e2e, hermes-e2e, ubuntu-repo-cloud-langchain-deepagents-code

Blockers

PRA-1 Blocker — Update the profile validator source hash

  • Location: agents/langchain-deepagents-code/validate-nemotron-ultra-profile.py:50
  • Category: correctness
  • Problem: The profile validator retains the previous profile-plugin source hash after this PR changes the plugin source.
  • Impact: The managed image validation rejects the changed reviewed plugin source, preventing a successful image build.
  • Fix: Replace EXPECTED_PLUGIN_SOURCE_SHA256 with the SHA-256 of the changed profile-plugin source.
  • Verification: Compare sha256 of profile-plugin/src/nemoclaw_deepagents_profile/__init__.py with EXPECTED_PLUGIN_SOURCE_SHA256, then inspect the validator comparison.
  • Test coverage: Keep or add a test that changes the profile-plugin source and verifies the validator rejects the unreviewed digest while accepting the checked-in source.
  • Evidence: agents/langchain-deepagents-code/validate-nemotron-ultra-profile.py:49-50 defines the stale EXPECTED_PLUGIN_SOURCE_SHA256. agents/langchain-deepagents-code/validate-nemotron-ultra-profile.py:183-186 compares the installed plugin source against that constant. agents/langchain-deepagents-code/dependency-review.md records the changed adapter module SHA-256 as 8fba11c64c561cad2568714363199f6ac28826e028f7743e19a2439a6de5a874.
1 warning · 0 suggestions

Warnings

Warnings do not block.

PRA-2 Warning — Test persisted upstream mode resets

  • Location: agents/langchain-deepagents-code/patch-managed-deepagents-code.py:77
  • Category: tests
  • Problem: The update adds approval-mode and startup-mode resets without a regression test that supplies hostile persisted-mode values through the managed entry paths.
  • Impact: A later patch change can remove or invert a mode reset and re-enable an upstream persisted approval or startup behavior without a focused regression failure.
  • Recommendation: Add a fixture-level test that supplies hostile environment and parsed approval_mode and startup_mode values through wrapper, direct-module, and CLI paths, then asserts the managed paths retain manual modes.
  • Verification: Inspect the direct-module patch fixture after supplying both environment variables and parsed attributes; confirm the patched process removes the variables and passes manual mode values.
  • Test coverage: A direct-module patch regression test that supplies non-manual DEEPAGENTS_CODE_APPROVAL_MODE and DEEPAGENTS_CODE_STARTUP_MODE values plus non-manual parsed modes, then verifies wrapper, module, and CLI paths cannot retain them.
  • Evidence: agents/langchain-deepagents-code/dcode-wrapper.sh:13 unsets DEEPAGENTS_CODE_APPROVAL_MODE and DEEPAGENTS_CODE_STARTUP_MODE. agents/langchain-deepagents-code/patch-managed-deepagents-code.py:77-78 removes both environment variables in the patched entrypoint. agents/langchain-deepagents-code/patch-managed-deepagents-code.py:171-175 sets present startup_mode and approval_mode arguments to manual. test/langchain-deepagents-code-direct-module-patch.test.ts has no reference to DEEPAGENTS_CODE_APPROVAL_MODE, DEEPAGENTS_CODE_STARTUP_MODE, args.startup_mode, or args.approval_mode.

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant