fix(inference): propagate OpenClaw provider timeout - #8569
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (6)
📝 WalkthroughWalkthrough
ChangesAgent timeout propagation
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
🌿 Preview your docs: https://nvidia-preview-pr-8569.docs.buildwithfern.com/nemoclaw |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 2c0eff9 in the TypeScript / code-coverage/cliThe overall coverage in commit 2c0eff9 in the Updated |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
2 additional E2E selections from the second opinionAdvisory only. The primary lane did not select these E2E jobs or targets.
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 2 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite against this exact revision. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
cv
left a comment
There was a problem hiding this comment.
Reviewed all six changed files and relevant timeout-generation context. The change preserves the accepted #2281 build-time timeout contract, adds the pinned OpenClaw 2026.7.1 provider field correctly, retains positive-integer validation and sandbox config immutability, and documents both consumers. No competing PR, unresolved finding, compatibility blocker, security finding, or missing documentation impact was found. The PR is open, mergeable, current with main, and has no submitted maintainer review.
Summary
OpenClaw configs currently apply
NEMOCLAW_AGENT_TIMEOUTto the whole agent run while leaving the provider request watchdog at OpenClaw's shorter default. This change applies the configured timeout to both layers so slow local inference can continue up to the agent deadline.Related Issue
Related to #8468. This PR addresses the independently reproduced timeout gap; the reported sandbox-readiness transition still needs the QA harness and lifecycle evidence requested on the issue.
Changes
NEMOCLAW_AGENT_TIMEOUTtomodels.providers.<provider-id>.timeoutSecondsas well asagents.defaults.timeoutSeconds.Type of Change
Quality Gates
Documentation Writer Review
docs-updateddocs/inference/configure-inference-timeouts.mdx,docs/reference/commands.mdxDGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpm exec -- vitest run --project integration test/generate-openclaw-config.test.ts -t 'propagates the agent timeout to the run and provider request|rejects invalid agent timeout values'(2 passed)npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)npm run docscompleted with 0 Fern errors and 2 non-blocking warnings.Signed-off-by: Julie Yaunches jyaunches@nvidia.com
Summary by CodeRabbit
New Features
Documentation
Tests