[Dev] Fuse standard RoPE packing for MLA and DSA - #6343
Draft
buptzyb wants to merge 3 commits into
Draft
Conversation
Signed-off-by: Robin Zhang <robinz@nvidia.com>
Signed-off-by: Robin Zhang <robinz@nvidia.com>
Signed-off-by: Robin Zhang <robinz@nvidia.com>
Contributor
Author
|
/ok to test e354f1f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[PE, NOPE]projection outputPerformance
Formal 8x B200 GLM-5.2 proxy A/B results, using 8 warmup and 20 measured iterations:
In the targeted absorbed-MLA packing region, the long-sequence path is reduced from 85 kernels to 2 kernels, and GPU kernel time falls from 0.848 ms to 0.099 ms per attention call. Whole self-attention GPU span falls by 10.6% for THD 4K and 11.5% for THD 32K.
The DSA indexer in-place integration is included for a cleaner packed-tensor path and shared primitive ownership. It is correctness- and trace-validated, but no additional end-to-end speedup is claimed for that follow-up beyond the MLA A/B results above.
Testing