fix(model): normalize Qwen3-Omni integer masks for TE - #5544
Open
hbhflw2000 wants to merge 3 commits into
Open
Conversation
Signed-off-by: hbhflw2000 <417911774@qq.com>
yaoyu-33
approved these changes
Aug 13, 2026
Contributor
|
/ok to test 9801179 |
Contributor
|
/ok to test 0690c89 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masked-token format
[B, 1, 1, S]expected by Transformer Engine.unsupported mask formats.
including expert-parallel export.
Problem
The processor and collator may emit 2D integer valid-token masks, while
the existing conversion only handled boolean masks. These integer masks
therefore bypassed normalization even though Transformer Engine expects
boolean masks with masked-token semantics.
The existing conversion tests also relied mainly on registry checks and
symmetric round trips, which could miss incorrect tensor ordering.
Scope
This follow-up is limited to:
It does not change the production tensor-mapping implementation,
packed-sequence handling, conversion APIs, dependencies, or Megatron Core.
Validation
zero skipped or NaN iterations.
one finite training step:
4.5638172.48072600Related
Follow-up to #4988, addressing the post-merge review comments on integral
attention masks and semantic tensor-mapping coverage.