Skip to content

Add missing config options for TE quantization recipes - #5408

Open
timmoon10 wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
timmoon10:tmoon/quant-recipe-attrs
Open

Add missing config options for TE quantization recipes#5408
timmoon10 wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
timmoon10:tmoon/quant-recipe-attrs

Conversation

@timmoon10

Copy link
Copy Markdown

What does this PR do ?

This PR adds config options that are supported in Mcore: quantizer factories for custom quantization recipes (NVIDIA/Megatron-LM#2005) and user-defined recipe attrs (NVIDIA/Megatron-LM#6341).

Changelog

  • Add missing config options for TE quantization recipes

GitHub Actions CI

See the CI section in the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Signed-off-by: Tim Moon <tmoon@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaoyu-33 yaoyu-33 added area:training Training loop, callbacks, and runtime integration feature New capabilities, enhancements, or enablement work needs-more-tests Requires additional L0 and L1 test coverage before merge needs-review PR is ready for code review and waiting on a reviewer labels Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:training Training loop, callbacks, and runtime integration feature New capabilities, enhancements, or enablement work needs-more-tests Requires additional L0 and L1 test coverage before merge needs-review PR is ready for code review and waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants