Skip to content

Acquisition GUI based on queue-monitor, that also allows for running locally. - #90

Merged
Jakub Wlodek (jwlodek) merged 11 commits into
NSLS2:mainfrom
jwlodek:hex-tuned-queue-monitor
Oct 5, 2026
Merged

Jakub Wlodek (jwlodek) merged 11 commits into
NSLS2:mainfrom
jwlodek:hex-tuned-queue-monitor

Conversation

@jwlodek

Copy link
Copy Markdown
Contributor
  • Working on queue-monitor variant, tuned for HEX
  • Working on DAQ UI prototype

@sligara7 Anthony Sligar (sligara7) left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to suggest just merging and cleaning up CI checks in a future PR.

@sligara7

Anthony Sligar (sligara7) commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Jakub Wlodek (@jwlodek) I put this together to fix some of the CI checks. jwlodek#3.

Fixed there (mock tests: back to main's baseline of 13 failed / 115 passed):

  1. DCLM.set calls forward_watcher_updates without importing it → every beam-mode change raised NameError.
  2. The merge with main dropped the ops-mode guard on the beam-current suspender (a8feb5c), so plans would pause during MAINTENANCE/SHUTDOWN.
  3. pytest collected src/hextools/gui → 13 Qt import errors in CI.
  4. tomo_alignment_scan tests still used the old positional arguments.

For you to decide (not changed):

  • RE_METADATA_KEYS is undefined in gui/__main__.py:195 (in the unused QtRunEngineManagerMonitor).
  • motors.py registers VelocityRespectingMotorMock as the default mock for every ophyd-async Motor at import time, which changes mock behaviour for anything that imports hextools.motors. A hextools subclass would avoid the global side effect.
  • The hex-gui pixi task used to connect to qs1; it now starts the in-process (local RunEngine) mode. The module docstring mentions QSERVER_HTTP_SERVER_URI, but nothing reads it, and the QueueServer path passes no API key.
  • The weather widget calls api.open-meteo.com every 10 minutes from the beamline workstation; on restricted egress that's a 10 s timeout. Worth checking that it runs off the GUI thread.
  • ntnda-qt-viewer is a git dependency with no pinned revision.

@jwlodek
Jakub Wlodek (jwlodek) merged commit da928a8 into NSLS2:main Oct 5, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants