test(hydraulics): implement plant hydraulics unit test suite - #1608
Open
johnpaulalex wants to merge 4 commits into
Open
test(hydraulics): implement plant hydraulics unit test suite#1608johnpaulalex wants to merge 4 commits into
johnpaulalex wants to merge 4 commits into
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds pFUnit unit test suites (
cohort,drive,geom,init,sizedep) forFatesPlantHydraulicsModundertesting/tests/unit/fates_plant_hydraulics_test/.Includes continuous parameter sweeps ($\theta$ ) across a 10-point gradient down to near-residual, verifying matric potential ($\Psi$ ) and fractional loss of conductivity ($) against independent Van Genuchten and Weibull theoretical oracles.
test_UpdatePlantPsiFTCFromTheta_sweep) that evaluate relative water content (Parent PR:
test/hydr-base)Preview of Child Branches / Stacked PRs:
fix/sum-btwn-depths+hydr-plant): FixesSumBetweenDepthssoil layer integration logic inFatesPlantHydraulicsMod.F90and adds pFUnit verification tests.Collaborators:
Linked issues addressed, if any:
Expectation of Answer Changes:
Description of generative AI usage (as necessary)
Google Antigravity was used to write the code and tests, followed by human-guided verification.
Checklist
Contributor
Integrator
Test Results:
CTSM (or) E3SM (specify which) test hash-tag: N/A
CTSM (or) E3SM (specify which) baseline hash-tag: N/A
FATES baseline hash-tag:
19ee3688Test Output:
[x] Executed pFUnit / CIME regression tests