Skip to content

refactor(hydraulics): implement MatSolve2D_explicit kernel and pFUnit test suite - #1604

Open
johnpaulalex wants to merge 2 commits into
NGEET:mainfrom
johnpaulalex:test/matsolve2d-explicit+hydr-base
Open

refactor(hydraulics): implement MatSolve2D_explicit kernel and pFUnit test suite#1604
johnpaulalex wants to merge 2 commits into
NGEET:mainfrom
johnpaulalex:test/matsolve2d-explicit+hydr-base

Conversation

@johnpaulalex

@johnpaulalex johnpaulalex commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description:

Refactors primitive plant hydraulics calculation routines (UpdatePlantPsiFTCFromTheta_explicit, UpdatePlantKmax_explicit, SumBetweenDepths, MatSolve2D_explicit) in biogeophys/FatesPlantHydraulicsMod.F90 to accept explicit parameter signatures rather than relying on global model singletons. Adds pFUnit test suite fortification for shallow partial layer integration (i_rhiz_b == 0) on non-uniform vertical soil grids, exact series resistance conservation, and multi-tier solver verification (smoke tests, extreme boundary cases, and mass conservation sweeps).

Specific notes

Collaborators:

Linked issues addressed, if any:

Expectation of Answer Changes:

  • Bit-for-Bit (B4B) with baseline master
  • Roundoff-level differences only
  • Expected Answer Changes (ECA)

Description of generative AI usage (as necessary)

Google Antigravity was used to write the code and tests, followed by human-guided verification.

Checklist

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary
  • Describe use of generative AI (if necessary)

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

Test Results:

CTSM (or) E3SM (specify which) test hash-tag: N/A
CTSM (or) E3SM (specify which) baseline hash-tag: N/A
FATES baseline hash-tag: 081aca6b

Test Output:
[x] Executed pFUnit / CIME regression tests

@johnpaulalex
johnpaulalex force-pushed the test/matsolve2d-explicit+hydr-base branch from 08bc085 to 1dea9a6 Compare August 19, 2026 02:34
@johnpaulalex johnpaulalex changed the title test(hydraulics): implement explicit plant hydraulics unit tests and SumBetweenDepths test refactor(hydraulics): implement MatSolve2D_explicit kernel and Level 1-3 pFUnit test suite Aug 19, 2026
@johnpaulalex
johnpaulalex marked this pull request as ready for review August 19, 2026 12:16
@johnpaulalex johnpaulalex changed the title refactor(hydraulics): implement MatSolve2D_explicit kernel and Level 1-3 pFUnit test suite refactor(hydraulics): implement MatSolve2D_explicit kernel and pFUnit test suite Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Finding Reviewers

Development

Successfully merging this pull request may close these issues.

1 participant