refactor(hydraulics): implement MatSolve2D_explicit kernel and pFUnit test suite - #1604
Open
johnpaulalex wants to merge 2 commits into
Open
refactor(hydraulics): implement MatSolve2D_explicit kernel and pFUnit test suite#1604johnpaulalex wants to merge 2 commits into
johnpaulalex wants to merge 2 commits into
Conversation
johnpaulalex
force-pushed
the
test/matsolve2d-explicit+hydr-base
branch
from
August 19, 2026 02:25
1772f70 to
7810090
Compare
…SumBetweenDepths test
johnpaulalex
force-pushed
the
test/matsolve2d-explicit+hydr-base
branch
from
August 19, 2026 02:34
08bc085 to
1dea9a6
Compare
johnpaulalex
marked this pull request as ready for review
August 19, 2026 12:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Refactors primitive plant hydraulics calculation routines (
UpdatePlantPsiFTCFromTheta_explicit,UpdatePlantKmax_explicit,SumBetweenDepths,MatSolve2D_explicit) inbiogeophys/FatesPlantHydraulicsMod.F90to accept explicit parameter signatures rather than relying on global model singletons. Adds pFUnit test suite fortification for shallow partial layer integration (i_rhiz_b == 0) on non-uniform vertical soil grids, exact series resistance conservation, and multi-tier solver verification (smoke tests, extreme boundary cases, and mass conservation sweeps).Specific notes
Collaborators:
Linked issues addressed, if any:
Expectation of Answer Changes:
Description of generative AI usage (as necessary)
Google Antigravity was used to write the code and tests, followed by human-guided verification.
Checklist
Contributor
Integrator
Test Results:
CTSM (or) E3SM (specify which) test hash-tag: N/A
CTSM (or) E3SM (specify which) baseline hash-tag: N/A
FATES baseline hash-tag:
081aca6bTest Output:
[x] Executed pFUnit / CIME regression tests