test(fates): Add EDAccumulateFluxesMod unit tests and document magic constants - #1600
Closed
johnpaulalex wants to merge 7 commits into
Closed
test(fates): Add EDAccumulateFluxesMod unit tests and document magic constants#1600johnpaulalex wants to merge 7 commits into
johnpaulalex wants to merge 7 commits into
Conversation
…ork/utils/path.py
Contributor
Author
|
Closed in favor of updated PR #1598. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds comprehensive pFUnit unit tests for
EDAccumulateFluxesModcovering carbon, respiration, N-fixation, C13 discrimination, and net uptake accumulation logic across normal, zero-GPP, subnormal floating point, multi-cohort, multi-patch, multi-site, multi-PFT, and zero-layer edge cases.All magic constants, filter flags (
3/1), sentinels (999.0_r8), and unit fixture rates in the test file include one-line explanatory comments per project documentation rules. Additionally, library path fallbacks were added to the unit test builder framework.Specific notes
Contributors other than yourself, if any:
Linked issues addressed, if any:
Description of generative AI usage:
Answer Changes & Scientific Impact
User Interface & Namelist Changes
Testing planned or performed, if any:
CTSM / CESM baseline hash-tag:
33155f41PR branch hash-tag:
ad0d728eRequirements before merge: