Create dri-ingestion-refactor-suggestions - #40
Open
lcdurkan wants to merge 3 commits into
Open
Conversation
"Write up suggested refactors for dri-ingester repository, to increase consistency and reduce duplication"
…uggestions.md Update to .md file
Update formatting
Contributor
|
I think in principle, all of these are good suggestions, and the ingestion repository would benefit from a refactor tidy. Just a little wary on the level of effort vs. demonstratable benefits. I think some of these changes can get consumed when working on other bits, e.g. implementation of a new ingestor for the EA 15-min rainfall data could also implement some changes to the API manager. |
Contributor
Author
|
Definitely fair point. Maybe some smaller changes could be made, with larger changes left alone, and maybe revisited after implementing new ingestors? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of suggested refactors for, and questions on, dri-ingester repository to increase consistency and reduce duplication.
Some can be converted into tickets.