FPM-1360 - manual flags - #355
Merged
Merged
Conversation
lcdurkan
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.ceh.ac.uk/browse/FPM-1360
Linked to: NERC-CEH/fdri-discovery#612
Overview
Adds a
manual_removalquality control method, which flags data points that appear in a hand-maintained list of known bad data points. These are points that have been checked by a person and found to be bad - e.g. sensor maintenance, known faults, site visits - and cannot be caught by a threshold or spike check.This is a temporary method until a proper manual flagging process exists in the FDRI system.
Main changes
qc_methods.py- newManualRemovalcheck. Reads the flagging file, then returns a mask for rows falling in any flagged period for that site and variable.qc_pipeline.py-QCPipeline.runnow putsnetworkandsite_idinto every method config__assets__/manual_flagging/<network>/manual_flags.csv- the flagging list, one file per network.ALLmeans every variable at that site, an emptyEND_DATETIMEruns to the end of the data.