FPM-1338 shared processing configs - #353
Merged
Merged
Conversation
lcdurkan
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.ceh.ac.uk/browse/FPM-1338
Overview
A data processing configuration can apply to more than one dataset, e.g.
fdri-se-fofad-01-pr-battv_1min-load_rawis a step in both thebattv_15minandbattv_30minplans, so the metadata API returns it with twoappliesToDatasetvalues.Previously, we assumed a 1-to-1 relationship so did
applies_to_dataset[0], so the config was set against whichever dataset the API happened to list first and dropped from the others. One of the datasets would fail withKeyError: 'http://fdri.ceh.ac.uk/id/data-processing-configuration/fdri-se-fofad-01-pr-battv_1min-load_raw'Main changes
map_processing_config_itemnow takes the specificAppliesToDatasetentry it is mapping for, and readsts_idand
site_idfrom that entry rather than fromapplies_to_dataset[0]._build_processing_configsnow takes the dataset IDs the configs were requested for. Each config is mapped once perrequested dataset it applies to, so which container a config lands on no longer depends on the order the API lists
those datasets in