Set StokesMOST column arrays before they are read by StokesXi() - #448
Open
alperaltuntas wants to merge 1 commit into
Open
Set StokesMOST column arrays before they are read by StokesXi()#448alperaltuntas wants to merge 1 commit into
alperaltuntas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets
cellHeight,uE_HandvE_Hfor the entire column beforecvmix_kpp_compute_StokesXi()is called. All three are passed to that routine in full, but within the k loop they were filled only down to the current layer, while the routine reads one layer deeper. For instance, atk=1it evaluatesuE(1)-uE(2)andzk(1)-zk(2). So the values read beyond the current layer were whatever the arrays still held from the previous column.The
uE_H/vE_Hloop is back where it was before #379 moved it into the k loop. The cell heights have been set within that loop since StokesMOST was introduced.This changes answers for STOKES_MOST = True.
testing: status: pr_mom, b4b unless STOKES_MOST = True.
Note: this should also fix issue 348.