chore(deepbook-v3): point mainnet LIQUIDATION_PACKAGE_ID at the upgraded-Pyth publication - #1214
Merged
Merged
Conversation
…ded-Pyth publication Mainnet `margin_liquidation` v4 (`0xf17bff1b…`) predates the upgraded-Pyth entrypoints: its `liquidation_vault` exposes `liquidate_base`/`liquidate_quote` only, while `MarginLiquidationsContract` targets the `_upgraded` pair. That left `liquidateBase` and `liquidateQuote` with no mainnet target in 2.0.0 — the second of the two release gates recorded in #1194. `LIQUIDATION_PACKAGE_ID` now points at the publication that closes it, `0xba2b39c0…`. The id is not on chain yet — `object(address:)` against mainnet GraphQL returns null — so nothing here is verified against a live package: not the version, not the lineage, not the module surface. Draft until the upgrade lands and those three are read on chain. The rest of the vault surface (deposit, withdraw, balance, swaps, trader authorization) takes no oracle and works against either id. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
tonylee08
deployed
to
sui-typescript-aws-kms-test-env
August 18, 2026 13:52 — with
GitHub Actions
Active
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The id is now published as margin_liquidation v5. Its liquidation_vault exposes liquidate_base_upgraded and liquidate_quote_upgraded, and its LIQUIDATION_VAULT type is still defined by the lineage's original 0x73c59388…, so the deployed vault stays valid across the upgrade.
tonylee08
deployed
to
sui-typescript-aws-kms-test-env
August 18, 2026 17:48 — with
GitHub Actions
Active
tonylee08
marked this pull request as ready for review
August 18, 2026 17:53
tonylee08
deployed
to
sui-typescript-aws-kms-test-env
August 18, 2026 17:53 — with
GitHub Actions
Active
The id change speaks for itself; the reasoning lives in the changeset and the PR.
tonylee08
deployed
to
sui-typescript-aws-kms-test-env
August 18, 2026 17:59 — with
GitHub Actions
Active
0xaslan
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
2.0.0 shipped
MarginLiquidationsContracttargetingliquidation_vault::liquidate_base_upgraded/liquidate_quote_upgraded, but mainnetmargin_liquidationis still v4 (0xf17bff1b…), which predates those entrypoints and exposes onlyliquidate_base/liquidate_quote. SoliquidateBaseandliquidateQuotecurrently have no mainnet target — the second of the two release gates called out in #1194.This points mainnet
LIQUIDATION_PACKAGE_IDat the publication that closes it:0xba2b39c026650fef52038c93c526fc5314a4286318a0d2a7054b65815178fb74. Patch release; no API change.Verified on chain — the package is live
The upgrade landed as
margin_liquidationv5 and every item from the draft checklist now checks out on mainnet:version: 5, and itsLIQUIDATION_VAULTtype is still defined by the lineage's original0x73c59388…, so the deployedLiquidationVault(0xae8e0606…) stays valid and no caller migrates an objectliquidation_vaultcarries both upgraded entrypoints — its public function list isauthorize_trader, balance, create_liquidation_vault, deauthorize_trader, deposit, liquidate_base, liquidate_base_upgraded, liquidate_quote, liquidate_quote_upgraded, swap_base_to_quote, swap_quote_to_base, withdrawliquidateBasePTB built by this SDK simulates successfully against it — target0xba2b39c02665…::liquidation_vault::liquidate_base_upgraded, simulation{"success": true, "error": null}, using the real vault and a liveSUI_SUIUSDEmargin managerNOT YET PUBLISHEDnote is dropped from the constant's comment, replaced with the verified stateEvery other vault builder — deposit, withdraw, balance, swaps, trader authorization — takes no oracle and resolves the same against either id.
Testnet is unchanged:
margin_liquidationv4 there (0x29bccec5…) already carries the upgraded pair.Test plan
pnpm --filter @mysten/deepbook-v3 test— 309 passed / 7 filespnpm turbo lint build --filter @mysten/deepbook-v3— 9 tasks green (tsc, oxlint, prettier, tsdown)0xf17bff1b…ismargin_liquidationversion 4, one moduleliquidation_vaultAI Assistance Notice