Skip to content

fix(demos): use official Sui gRPC in browsers - #645

Open
ducnmm wants to merge 1 commit into
devfrom
hotfix/noter-mainnet-rpc-cors
Open

fix(demos): use official Sui gRPC in browsers#645
ducnmm wants to merge 1 commit into
devfrom
hotfix/noter-mainnet-rpc-cors

Conversation

@ducnmm

@ducnmm ducnmm commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • move Noter and Researcher browser clients to the official Sui gRPC transport
  • configure NEXT_PUBLIC_SUI_GRPC_URL at image build time
  • normalize object, dynamic-field, and transaction-change responses across gRPC and JSON-RPC fallback paths

Production incident

The default mainnet JSON-RPC endpoint rejects browser CORS preflights. The official Sui gRPC-Web service supports the required CORS paths, so both demos now use SuiGrpcClient against https://fullnode.mainnet.sui.io:443.

Validation

  • Noter ESLint and TypeScript pass
  • Researcher TypeScript passes
  • live mainnet gRPC registry/dynamic-field lookup succeeds
  • official gRPC-Web CORS preflights succeed
  • production Noter bundle contains the official gRPC URL and no third-party RPC URL

@ducnmm
ducnmm requested a review from harrymove-ctrl August 14, 2026 09:11
@ducnmm

ducnmm commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

@harrymove-ctrl Production Noter Google/Enoki login is currently blocked by the mainnet fullnode CORS policy. All required checks pass; could you please review this hotfix?

@ducnmm
ducnmm requested review from hungtranphamminh and jessiemongeon1 and removed request for hungtranphamminh and jessiemongeon1 August 14, 2026 10:04
@railway-app
railway-app Bot temporarily deployed to Walrus Memory / production August 14, 2026 10:07 Inactive
@ducnmm ducnmm changed the title fix(noter): allow browser-safe Sui RPC override fix(demos): allow browser-safe Sui RPC overrides Aug 14, 2026
@railway-app
railway-app Bot temporarily deployed to Walrus Memory / production August 14, 2026 10:15 Inactive
@ducnmm
ducnmm force-pushed the hotfix/noter-mainnet-rpc-cors branch from e1c6952 to 174624a Compare August 14, 2026 10:27
@railway-app
railway-app Bot temporarily deployed to Walrus Memory / production August 14, 2026 10:27 Inactive
@ducnmm ducnmm changed the title fix(demos): allow browser-safe Sui RPC overrides fix(demos): use official Sui gRPC in browsers Aug 14, 2026
@ducnmm
ducnmm requested a review from harrymove-ctrl August 14, 2026 10:29
@ducnmm
ducnmm changed the base branch from main to dev August 14, 2026 11:20
@ducnmm
ducnmm force-pushed the hotfix/noter-mainnet-rpc-cors branch from 174624a to ec6a9b8 Compare August 14, 2026 11:28
@railway-app
railway-app Bot temporarily deployed to Walrus Memory / production August 14, 2026 11:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants