This repository was archived by the owner on Feb 10, 2025. It is now read-only.
Backport changes to collection patching to make LCIO -> EDM4hep conversion work - #6
Open
tmadlener wants to merge 3 commits into
Open
Backport changes to collection patching to make LCIO -> EDM4hep conversion work#6tmadlener wants to merge 3 commits into
tmadlener wants to merge 3 commits into
Conversation
Needed to fix 'definition of implicit copy constructor for 'LCObject' is deprecated because it has a user-declared destructor'
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
|
I think we don't need this anymore? |
Author
|
If it hasn't been missed so far, I suppose we will pick up all the fixes once we switch off the fork(?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
This is necessary to make the standalone converter work. This is the minimal solution. In principle we could also try to pick up all upstream changes.