Skip to content

ums: self-switch to manual on classifier denial; apply-all scope - #4678

Merged
d-morrison merged 2 commits into
mainfrom
ums-auto-classifier-apply-all
Oct 23, 2026
Merged

d-morrison merged 2 commits into
mainfrom
ums-auto-classifier-apply-all

Conversation

@d-morrison

Copy link
Copy Markdown
Collaborator

Requested by Ezra

UMS pass from the 2026-10-22 branch-ruleset apply session.

  • shared/workflow/ask-for-manual-approval.md: when set_session_permission_mode exists, switch to default yourself and rerun so the user gets a real prompt, then request auto again. After a classifier denial, say no prompt was shown rather than telling the user to approve one. Do not ask "retry?" or "disable auto?" when the self-switch is available.
  • shared/workflow/repo-templates.md: naming repos on apply-all.sh restricts the run to them, so rerun with no names and finish with a dry run showing 0 MISSING.
  • skills/daytb/SKILL.md: a daytb reply to a "retry?" or "disable auto?" question means act on the recommendation; avoid the word "owed" in replies to the user.

Corpus grep found existing coverage only for the manual-mode switch (use-existing-pr-branch.md, ask-for-manual-approval.md), so those entries were extended in place. Gates run: check-links.py, check-memory-file-size.py --strict, semantic-line-breaks.py --write.

🤖 Generated with Claude Code

… scope; daytb and "owed" notes

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@d-morrison d-morrison self-assigned this Oct 22, 2026
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


No formatting issues found. This is a small, well-scoped, prose-only memory/skill update consistent with the corpus's own conventions (case records, Do/Don't pairs, linked fragments). Links resolve, no size-cap violations, no non-ASCII punctuation, no apparent hallucinated tool names beyond a plausibly real but unverifiable MCP tool name gated behind an availability check, and the apply-all.sh claims (override syntax, MISSING status label) check out against the actual script.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "c01489fecd640e8730f555471b274e33e247ceeb",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Checked shared/workflow/ask-for-manual-approval.md, shared/workflow/repo-templates.md, and skills/daytb/SKILL.md for broken crossrefs, hallucinated tool/script names, and malformed markup; links resolve and the apply-all.sh override syntax and MISSING status label match the actual script.",
  "holistic_assessment": "Scope is a single UMS memory/skill update with no code behavior change, no regression risk, no test requirement, and no conflict with existing entries on owed-word usage or mode-switch guidance."
}

Reviewed commit: c01489f

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.6220 (review) — run

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-23 05:10 UTC

@d-morrison

d-morrison commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator Author

Agent comment (Claude Code, Remote Control session): cross-model adversarial review waived under adversarial-self-review.md#waiver-when-no-cross-model-reviewer-can-run.
Routes tried once each on head c01489fe:

  • agy: RESOURCE_EXHAUSTED (code 429): Individual quota reached, resets in about 27h.
  • opencode / OpenCode Go: no CLI on this machine and no credential in the environment (opencode.ai/zen/go/v1/models is reachable, but there is no key to send).
  • codex: not used, per Ezra's standing rule.
  • gemini: not installed.
    Claude review is clean on this head; CI must be green before merge. Merging under Ezra's mwc all ("mwc all", 2026-10-23T04:43Z).

Posted by Claude Code (AI agent) --- not written by a human.

@d-morrison
d-morrison merged commit 659da86 into main Oct 23, 2026
20 checks passed
@d-morrison
d-morrison deleted the ums-auto-classifier-apply-all branch October 23, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant