Repository navigation
ums: self-switch to manual on classifier denial; apply-all scope - #4678
Conversation
… scope; daytb and "owed" notes Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
|
Claude finished review — View run No formatting issues found. This is a small, well-scoped, prose-only memory/skill update consistent with the corpus's own conventions (case records, Do/Don't pairs, linked fragments). Links resolve, no size-cap violations, no non-ASCII punctuation, no apparent hallucinated tool names beyond a plausibly real but unverifiable MCP tool name gated behind an availability check, and the VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "c01489fecd640e8730f555471b274e33e247ceeb",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Checked shared/workflow/ask-for-manual-approval.md, shared/workflow/repo-templates.md, and skills/daytb/SKILL.md for broken crossrefs, hallucinated tool/script names, and malformed markup; links resolve and the apply-all.sh override syntax and MISSING status label match the actual script.",
"holistic_assessment": "Scope is a single UMS memory/skill update with no code behavior change, no regression risk, no test requirement, and no conflict with existing entries on owed-word usage or mode-switch guidance."
}Reviewed commit: c01489f |
2026-10-23 05:10 UTC |
|
Agent comment (Claude Code, Remote Control session): cross-model adversarial review waived under
Posted by Claude Code (AI agent) --- not written by a human. |
Requested by Ezra
UMS pass from the 2026-10-22 branch-ruleset apply session.
shared/workflow/ask-for-manual-approval.md: whenset_session_permission_modeexists, switch todefaultyourself and rerun so the user gets a real prompt, then requestautoagain. After a classifier denial, say no prompt was shown rather than telling the user to approve one. Do not ask "retry?" or "disable auto?" when the self-switch is available.shared/workflow/repo-templates.md: naming repos onapply-all.shrestricts the run to them, so rerun with no names and finish with a dry run showing 0MISSING.skills/daytb/SKILL.md: adaytbreply to a "retry?" or "disable auto?" question means act on the recommendation; avoid the word "owed" in replies to the user.Corpus grep found existing coverage only for the manual-mode switch (
use-existing-pr-branch.md,ask-for-manual-approval.md), so those entries were extended in place. Gates run:check-links.py,check-memory-file-size.py --strict,semantic-line-breaks.py --write.🤖 Generated with Claude Code