Cache coin symbol counts and refactor duplicate-symbol detection in pool.js - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
poolStats.coinsfor each lookup.poolStats.coinsreference hasn't changed by caching computed symbol counts.Description
WeakMapnamedcoinSymbolCountsCacheto cache symbol count maps keyed by thepoolStatsobject.hasDuplicateCoinSymbolto early-return when the slug is empty and to consult cached counts via a newgetCoinSymbolCountsfunction.getCoinSymbolCountsto compute aMapof slug -> count fromcoinStatsRows(poolStats), cache it with thecoinsreference ascoinsRef, and return the counts.counts.get(wanted) > 1).Testing
npm test, which passed successfully.coinRouteId,coinRouteSlug, andhasDuplicateCoinSymbol, all of which passed.Codex Task