Skip to content

fix(i18n): support dynamic translation for command labels #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jefsky wants to merge 1 commit into
base: dev
Choose a base branch
from
+4 −1
Open

fix(i18n): support dynamic translation for command labels #1412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/apis/app/shortKey/shortKeyHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ class ShortKeyHandler {
enable: true,
name: config.name,
label: config.label,
labelKey: config.labelKey,
key: config.key
}
})
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/pages/ShortKey.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
:label="$T('SHORTCUT_NAME')"
>
<template #default="scope">
{{ scope.row.label ? scope.row.label : scope.row.name }}
{{ scope.row.labelKey ? $T(scope.row.labelKey) : (scope.row.label ? scope.row.label : scope.row.name) }}
</template>
</el-table-column>
<el-table-column
Expand Down
2 changes: 2 additions & 0 deletions src/universal/types/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,15 @@ interface IShortKeyConfig {
key: string // 按键
name: string
label: string
labelKey?: string
from?: string
}

interface IPluginShortKeyConfig {
key: string
name: string
label: string
labelKey?: string
handle: IShortKeyHandler
}

Expand Down