Fix incorrect method names and incomplete trigger description in InteractionTracker state table - #126
Draft
John Kennedy (GrantMeStrength) with Copilot wants to merge 2 commits into
Draft
Fix incorrect method names and incomplete trigger description in InteractionTracker state table#126John Kennedy (GrantMeStrength) with Copilot wants to merge 2 commits into
John Kennedy (GrantMeStrength) with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix incorrect documentation for InteractionTracker
Fix incorrect method names and incomplete trigger description in InteractionTracker state table
Jul 23, 2026
Copilot started reviewing on behalf of
John Kennedy (GrantMeStrength)
July 23, 2026 20:47
View session
There was a problem hiding this comment.
Pull request overview
Updates the InteractionTracker documentation to correct method names in the state transition table and to accurately describe additional triggers for the Idle → Inertia transition (including mouse wheel input), aligning the docs with observed runtime behavior and WinAppSDK API surface.
Changes:
- Replaces non-existent
TryUpdate*WithVelocityreferences withTryUpdate*WithAdditionalVelocityin relevant state transitions. - Revises the Idle → Inertia trigger description to include user input (e.g., mouse wheel scroll) as a valid trigger, not only
TryUpdate*calls.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
InteractionTrackerstate transition table contained two categories of errors: incorrect method names (TryUpdatePositionWithVelocity/TryUpdateScaleWithVelocity— these methods don't exist) and an overly restrictive "only happens when" claim for the Idle→Inertia transition that excluded mouse wheel input as a trigger.Changes
TryUpdatePositionWithAdditionalVelocity/TryUpdateScaleWithAdditionalVelocity.Note: When the Idle→Inertia transition is triggered by mouse wheel (rather than a
TryUpdate*call), therequestIdin the state-entered args will be0, consistent with how user-input-driven transitions are reported.