Skip to content

Fix incorrect method names and incomplete trigger description in InteractionTracker state table - #126

Draft
John Kennedy (GrantMeStrength) with Copilot wants to merge 2 commits into
docsfrom
copilot/fix-interactiontracker-documentation
Draft

Fix incorrect method names and incomplete trigger description in InteractionTracker state table#126
John Kennedy (GrantMeStrength) with Copilot wants to merge 2 commits into
docsfrom
copilot/fix-interactiontracker-documentation

Conversation

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown

The InteractionTracker state transition table contained two categories of errors: incorrect method names (TryUpdatePositionWithVelocity/TryUpdateScaleWithVelocity — these methods don't exist) and an overly restrictive "only happens when" claim for the Idle→Inertia transition that excluded mouse wheel input as a trigger.

Changes

  • Idle → Inertia: Removed the incorrect "only happens" qualifier; added that input such as mouse wheel scroll can also trigger this transition. Corrected method names to TryUpdatePositionWithAdditionalVelocity / TryUpdateScaleWithAdditionalVelocity.
  • Inertia → Inertia: Same method name corrections.
  • CustomAnimation → Inertia: Same method name corrections.

Note: When the Idle→Inertia transition is triggered by mouse wheel (rather than a TryUpdate* call), the requestId in the state-entered args will be 0, consistent with how user-input-driven transitions are reported.

Copilot AI changed the title [WIP] Fix incorrect documentation for InteractionTracker Fix incorrect method names and incomplete trigger description in InteractionTracker state table Jul 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the InteractionTracker documentation to correct method names in the state transition table and to accurately describe additional triggers for the Idle → Inertia transition (including mouse wheel input), aligning the docs with observed runtime behavior and WinAppSDK API surface.

Changes:

  • Replaces non-existent TryUpdate*WithVelocity references with TryUpdate*WithAdditionalVelocity in relevant state transitions.
  • Revises the Idle → Inertia trigger description to include user input (e.g., mouse wheel scroll) as a valid trigger, not only TryUpdate* calls.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect documentation for InteractionTracker

3 participants