fix: display result sets from stored procedure calls (CALL/EXEC/EXECUTE) - #265
Closed
probeldev wants to merge 1 commit into
Closed
fix: display result sets from stored procedure calls (CALL/EXEC/EXECUTE)#265probeldev wants to merge 1 commit into
probeldev wants to merge 1 commit into
Conversation
Owner
|
Thank you @probeldev for the original implementation. I confirmed the result-set bug and carried the fix forward in #287, with provider-specific routing plus regression coverage for MySQL/MariaDB and SQL Server. That replacement also preserves Oracle/Firebird non-query behavior, drains all result sets, and distinguishes SQL Server stored procedures from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, queries like CALL getalltheme() are classified as non-queries, so the UI only shows 61 row(s) affected instead of the actual result set. This PR treats stored procedure calls as row-returning queries and adds MySQL-specific handling for multiple result sets.
Before:
After:
