Skip to content

update intracellular in first time step - #364

Merged
drbergman merged 2 commits into
MathCancer:developmentfrom
drbergman:fix-update-intracellular-first-step
Aug 15, 2026
Merged

drbergman merged 2 commits into
MathCancer:developmentfrom
drbergman:fix-update-intracellular-first-step

Conversation

@drbergman

@drbergman drbergman commented Feb 18, 2025 •

Copy link
Copy Markdown
Collaborator

Low priority PR that fixes bug causing intracellular updates to skip the first diffusion time step at t=0. I don't believe that PhysiBoSS or PhysiCelldFBA require this step to be skipped, but please inform if it is necessary :)

It is possible that rules that depend on variables expected to be set in a post_intracellular_update function could receive unexpected inputs causing unintended behavior in the first advance_bundled_phenotype_functions and subsequent mechanics updates.

  • this change allows intracellular updates to occur in the first diffusion step
  • before, they had to wait one diffusion step to update (if there's a reason for this, it's lost on me)
  • removed need for initialzed [sic] field in Cell_Container class
  • also make easier-to-parse logic and variable names for when to update phenotype and mechanics

- this change allows intracellular updates to occur in the first diffusion step
- before, they had to wait one diffusion step to update (I don't see a reason why)
- removed need for `initialzed` [sic] field in `Cell_Container` class
- also make easier-to-parse logic and variable names for when to update phenotype and mechanics
@drbergman
drbergman requested a review from Copilot April 4, 2025 15:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@drbergman drbergman self-assigned this May 22, 2025
@vincent-noel

Copy link
Copy Markdown
Collaborator

I don't think there is a reason, and I don't see how.
In the case of PhysiBoSS, if there is a need to wait, there is a special parameter which can be set (start_time) for example to allow for a gradient to reach equilibrium.

@drbergman

Copy link
Copy Markdown
Collaborator Author

Merge once conflict is resolved.

@drbergman

Copy link
Copy Markdown
Collaborator Author

waiting for checks to past before merging. had to bring in the change to pre-update intracellular first

@drbergman
drbergman merged commit 20f3f40 into MathCancer:development Aug 15, 2026
185 checks passed
@drbergman
drbergman deleted the fix-update-intracellular-first-step branch August 15, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants