馃悰 Fix M428 home offset calculation - #28538
Open
jujumo wants to merge 2 commits into
Open
Conversation
Since home_offset is applied by G28 (position = base_home_pos + home_offset) rather than shifting the workspace, M428 was measuring against the wrong reference: - base_home_pos is already applied by homing, so subtracting it again shifted the coordinate system by [XYZ]_MIN_POS. With a non-zero MIN_POS the resulting offset was wrong by exactly that amount. - The offset already in effect is part of the current position, so a second M428 discarded the previous calibration instead of keeping it. Take the existing home_offset into account and use 0 as the reference point, falling back to the endstop position only for an axis homing to max, as documented. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since home_offset is applied by G28 (position = base_home_pos + home_offset) rather than shifting the workspace, M428 was measuring against the wrong reference:
Take the existing home_offset into account and use 0 as the reference point, falling back to the endstop position only for an axis homing to max, as documented.
Description
Requirements
Benefits
Configurations
Related Issues