feat: added patched path and spectrumreader - #60
Merged
Conversation
sander-willems-bruker
requested review from
grosenberger-bruker
and
a lite review from Copilot
August 18, 2026 11:01
grosenberger-bruker
approved these changes
Aug 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds optional (patched feature) support for a new “patched” timsTOF path type and wires it through the spectrum/precursor readers and converter selection so the crate can recognize and operate on patched datasets.
Changes:
- Add
TimsTofFileType::Patched(...)and detection inTimsTofPath::new. - Integrate
timsrust_patched::PatchedSpectrumReaderintoSpectrumReader(with random-access explicitly unsupported). - Handle the patched file type in precursor reader construction and in m/z, IM, and RT converter selection.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| crates/timsrust/src/timstof.rs | Adds a patched file type variant and path auto-detection logic. |
| crates/timsrust/src/spectrum_reader.rs | Adds a patched-backed spectrum reader variant plus an error for unsupported random access. |
| crates/timsrust/src/precursor_reader.rs | Rejects patched datasets for precursor reading and introduces an error variant. |
| crates/timsrust/src/converters.rs | Adds patched file type handling for converter construction. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.