Path refactoring 2 - #201
Open
mschwoer wants to merge 4 commits into
Open
Conversation
--- # Conversation that produced these changes --- ## User prompt "now C3" "get_host_frame pertains to the msqc docker container, right? please change the docstring" "also, naming: give me alternatives for roots and frame" ## Clarifying round 1 Q: Which naming pair for the two new concepts in path_frames.py? - View + Roots (Recommended) - Frame + Roots (as written) - View + Locations <-- chosen - PathResolver + Anchors Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
--- # Conversation that produced these changes --- ## User prompt "go on with the next slice" "rename CONTAINER -> AIRFLOW_CONTAINER_VIEW ?" "yes, rename get_host_view to get_docker_host_view too" Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
--- # Conversation that produced these changes --- ## User prompt "go on with the next slice" Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
--- # Conversation that produced these changes --- ## User prompt "why again are get_docker_host_view and get_cluster_view not constants?" "how could the tests be changed to enable view being constants?" "option B" Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second slice of refactoring the path handling.