Path refactoring - #200
Open
mschwoer wants to merge 4 commits into
Open
Conversation
--- # Conversation that produced these changes --- ## User prompt "I feel path handling needs to be refactored. There's relative paths, and then there's different views (e.g. from within airflow containers, from a job running on a linux cluster, ...) (Ignore the docker msqc container for now). First, give a succint overview of the various types of paths and the code parts where paths are used and defined." "write this to a markdown" "okay, in table 1.: move "Relative paths" to position 1.1, docker-view to 1.5 .." Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
--- # Conversation that produced these changes --- ## User prompt "I want to refactor this code, for clarity, and to enable a second "cluster view", this time from a windows machine. Also, the paths could be resolved differently depending on the nature of the quanting env. What designs would you propose? Rate them by pros & cons." "Write this result to a .md file, then create a implementation plan which splits the refactoring into sensible logical chunks" ## Clarifying round 1 Q: What is the Windows target for the second cluster view? - Single Windows box via SSH/WinRM - Windows scheduler (HPC Pack / slurm-like) - Drop-folder / file_based <-- chosen: "could be all of the above" Q: How does the Windows machine see the data (backup, settings, output, software)? - UNC paths (\\server\share\...) - Mapped drive letters (Z:\...) - Local disk, data staged/copied first <-- chosen: "both 1. and 2." Q: Scope you want me to plan next? - D2 + D3 together (Recommended) - D2 only, first <-- chosen - Nothing yet — write the design doc Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
--- # Conversation that produced these changes --- ## User prompt "start with C1" Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
--- # Conversation that produced these changes --- ## User prompt "now C2" Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan and first slice of refactoting the messy path handling.