Config param placeholders - #193
Open
mschwoer wants to merge 8 commits into
Open
Conversation
---
# Conversation that produced these changes
---
## User prompt
"the placeholders for introducing custom commands should be surrounded by "{}" @airflow_src/dags/impl/processor_impl.py#L254-264"
## Clarifying round 1
Q: Existing settings in the DB use bare placeholders (RAW_FILE_PATH). After the switch to {RAW_FILE_PATH} they silently stop substituting. How should this be handled?
- Fail loudly on leftovers
- Clean break, no guard <-- chosen
- Accept both syntaxes
Q: Braces have to be allowed through check_for_malicious_content. Which scope?
- New allow_placeholders flag
- Add {} to the with-spaces pattern
- Other <-- chosen: "validate after substitution only"
## User prompt
"decision 2: the webapp should know which parameters exists and to a "dummy substitution" before validating"
## Clarifying round 2
Q: Where should the placeholder registry live, and should the webapp help list be generated from it?
- New shared/config_params.py, generated help <-- chosen
- New module, hand-written help
- Put it in shared/keys.py
## User prompt
"check again that all your desired changes are there"
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
# Conflicts: # webapp/pages_/settings.py
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use braces as placeholder delimiters