[claude] Add CandidateCollection filtering, min_fragments, and z-score filter - #119
Open
GeorgWa wants to merge 1 commit into
Open
[claude] Add CandidateCollection filtering, min_fragments, and z-score filter#119GeorgWa wants to merge 1 commit into
GeorgWa wants to merge 1 commit into
Conversation
…z-score filter - Add filter_by_score and filter_by_keys to CandidateCollection to avoid Rust-DataFrame round-trips in the Python pipeline - Add filter_by_score to CandidateFeatureCollection - Add min_fragments parameter to SelectionParameters for apex fragment count cutoff - Add zscore_filter_mask function for batched z-score computation via ndarray - Fix typo in candidate_scoring.py (competetive -> competitive) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 28, 2026
mschwoer
approved these changes
Mar 3, 2026
Comment on lines
+100
to
+107
| py: Python, | ||
| features: PyReadonlyArray2<'_, f64>, | ||
| col_indices: Vec<usize>, | ||
| means: Vec<f64>, | ||
| stds: Vec<f64>, | ||
| signs: Vec<f64>, | ||
| threshold: f64, | ||
| ) -> PyResult<PyObject> { |
Collaborator
There was a problem hiding this comment.
what's the rustonic way of documenting function signatures? :-p
|
|
||
| let mut mask = Array1::<bool>::from_elem(n_rows, false); | ||
|
|
||
| const BATCH_SIZE: usize = 500_000; |
Collaborator
There was a problem hiding this comment.
could/should this be a parameter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter_by_scoreandfilter_by_keystoCandidateCollectionto keep candidates in Rust-native format through the Python pipelinefilter_by_scoretoCandidateFeatureCollectionmin_fragmentsparameter toSelectionParametersfor apex fragment count cutoff during selectionzscore_filter_maskPython function for batched z-score computation via ndarrayStacked on #118.
🤖 Generated with Claude Code
PR Stack