Repository navigation
Conversation
…router does not serve (MAG-5178) Eight gRPC methods answer with a stream of replies, and the specs did not mark them as subscriptions: - SUI: sui.rpc.v2.LedgerService/ListCheckpoints, ListTransactions and ListEvents. - CONCORDIUM: concordium.v2.Queries/GetAccountList, GetAncestors, GetBakerList, GetBlockItems, and DryRun (a two-way stream). The router sent such a call to a provider as a one-reply call. With the method's definition known, it refused it inside the provider attempt and counted the provider as failed. Without it, a reply of two or more items ended in a "cardinality violation" from the gRPC library, also counted against the provider. Switched off, the call is refused when it is parsed, before any provider is asked. SUIT and SUID import SUI, and CONCORDIUMT imports CONCORDIUM. They take the switch-off with the import: checked by loading all five specs through the router's spec expansion and parsing each method. The subscribe methods (SubscribeCheckpoints and the rest) stay served. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
🤖 Spec pipeline started on PR open — running Phase 8 → 11. Results post here as comments. View run |
|
The router side is Magma-Devs/smart-router#764: with it, a call to a switched-off gRPC method gets 🤖 Generated with Claude Code |
|
Phase 8 — smart-router boot + probe (SUI / SUIT) Resumable run, Phases 8–11. Endpoints self-researched (no
The four claims this PR makes — all CONFIRMED:
Interface coverage note: the whole Correction to a pipeline assumption, worth recording: this router build does expose Sui Smart-Router Method Probe Report
PR under testPR #210 sets Step 3.5 — Parse-directive & verification runtime check (mainnet)
No parse-failure signatures (
No Addon & extension coverageADDONS: none declared. Confirmed by direct Per-method tablegRPC (direct-upstream unless noted) —
|
| Method | Interface | Path | Classification | Upstream notes | Notes |
|---|---|---|---|---|---|
sui.rpc.v2.LedgerService/ListCheckpoints |
grpc | through-router (localhost:3360) |
PASS (expected-refusal) | n/a | Router returned Code: Unknown, Message: "...failed to getSupportedApi gRPC ErrMsg: api is disabled {apiKey:{Name:sui.rpc.v2.LedgerService/[redacted]...}}". Log relay_end shows outcome:"rejected_before_dispatch", served_by:"", attempts:[], latency 363.8µs — no provider was ever asked. |
sui.rpc.v2.LedgerService/ListEvents |
grpc | through-router | PASS (expected-refusal) | n/a | Same api is disabled / rejected_before_dispatch evidence. |
sui.rpc.v2.LedgerService/ListTransactions |
grpc | through-router | PASS (expected-refusal) | n/a | Same api is disabled / rejected_before_dispatch evidence. |
sui.rpc.v2.SubscriptionService/SubscribeCheckpoints |
grpc | through-router (gRPC server stream, localhost:3360) |
PASS | n/a | ≥5 checkpoint messages received within 30s window. |
sui.rpc.v2.SubscriptionService/SubscribeTransactions |
grpc | through-router | PASS | n/a | Watermark + transaction messages received within 30s window. |
sui.rpc.v2.SubscriptionService/SubscribeEvents |
grpc | through-router | PASS | n/a | Watermark + event messages received within 30s window. |
sui.rpc.v2.LedgerService/GetServiceInfo |
grpc | direct-upstream | PASS | chainId, epoch, checkpointHeight returned | |
sui.rpc.v2.LedgerService/GetCheckpoint |
grpc | direct-upstream | PASS | live sequence_number=346849654 |
|
sui.rpc.v2.LedgerService/GetObject |
grpc | direct-upstream | PASS | object_id=0x5 (System State) |
|
sui.rpc.v2.LedgerService/BatchGetObjects |
grpc | direct-upstream | PASS | object_id=0x5 |
|
sui.rpc.v2.LedgerService/BatchGetTransactions |
grpc | direct-upstream | PASS | live tx digest 6DaJKwKBqWLgPqBbE6LaKfKUWGeJGJcXJpLvPUaML9uB |
|
sui.rpc.v2.LedgerService/GetTransaction |
grpc | direct-upstream | PASS | same live digest | |
sui.rpc.v2.LedgerService/GetEpoch |
grpc | direct-upstream | PASS | latest epoch 1316 | |
sui.rpc.v2.MovePackageService/GetPackage |
grpc | direct-upstream | PASS | package_id=0x2 |
|
sui.rpc.v2.MovePackageService/GetFunction |
grpc | direct-upstream | PASS | 0x2::coin::value |
|
sui.rpc.v2.MovePackageService/GetDatatype |
grpc | direct-upstream | PASS | 0x2::coin::Coin |
|
sui.rpc.v2.MovePackageService/ListPackageVersions |
grpc | direct-upstream | PASS | package_id=0x2 |
|
sui.rpc.v2.NameService/LookupName |
grpc | direct-upstream | PASS | example.sui resolved to a record |
|
sui.rpc.v2.NameService/ReverseLookupName |
grpc | direct-upstream | PASS-existence | live sender address 0x1e63...a64 |
NotFound — address has no SuiNS reverse record; method reachable, well-formed request |
sui.rpc.v2.SignatureVerificationService/VerifySignature |
grpc | direct-upstream | PASS-existence | InvalidArgument: missing signature scheme flag on a syntactically-minimal signature — method dispatched, rejects malformed input |
|
sui.rpc.v2.StateService/GetBalance |
grpc | direct-upstream | PASS | live address, 0x2::sui::SUI |
|
sui.rpc.v2.StateService/GetCoinInfo |
grpc | direct-upstream | PASS | 0x2::sui::SUI |
|
sui.rpc.v2.StateService/ListBalances |
grpc | direct-upstream | PASS | live address | |
sui.rpc.v2.StateService/ListDynamicFields |
grpc | direct-upstream | PASS | parent=0x5 |
|
sui.rpc.v2.StateService/ListOwnedObjects |
grpc | direct-upstream | PASS | live address | |
sui.rpc.v2.TransactionExecutionService/ExecuteTransaction |
grpc | — | SKIP | category.stateful=1 |
would broadcast a transaction |
sui.rpc.v2.TransactionExecutionService/SimulateTransaction |
grpc | direct-upstream | PASS-existence | InvalidArgument: error converting from protobuf ... unexpected end of input on minimal bcs — method dispatched, rejects malformed input |
|
sui.rpc.v2alpha.ProofService/GetCheckpointObjectProof |
grpc | direct-upstream | PASS | live checkpoint=346849654, object_id=0x5 |
Note: the smart-router's own gRPC listener unexpectedly does expose server reflection (grpc.reflection.v1.ServerReflection listed via grpcurl -plaintext localhost:3360 list), contrary to the general assumption in this phase's brief. This made it possible to call the three disabled methods and the three subscriptions directly through the router via grpcurl, which is why those six rows are labelled through-router rather than falling back to log-only evidence.
GraphQL (through-router, localhost:3361) — upstream https://graphql.mainnet.sui.io/graphql
| Method | Interface | Path | Classification | Notes |
|---|---|---|---|---|
chainIdentifier |
graphql | through-router | PASS | |
serviceConfig |
graphql | through-router | PASS | |
protocolConfigs |
graphql | through-router | PASS | version 141 |
node |
graphql | through-router | PASS | global ID resolved from a live object{id} lookup |
address |
graphql | through-router | PASS | live address |
checkpoint |
graphql | through-router | PASS | live sequence number |
checkpoints |
graphql | through-router | PASS | |
coinMetadata |
graphql | through-router | PASS | 0x2::sui::SUI |
epoch |
graphql | through-router | PASS | live epoch 1316 |
epochs |
graphql | through-router | PASS | |
events |
graphql | through-router | PASS | empty page, valid response |
nameRecord |
graphql | through-router | PASS | example.sui |
object |
graphql | through-router | PASS | 0x2 |
objects |
graphql | through-router | PASS | required filter arg supplied |
objectVersions |
graphql | through-router | PASS | |
package |
graphql | through-router | PASS | 0x2 |
packages |
graphql | through-router | PASS | |
packageVersions |
graphql | through-router | PASS | |
transaction |
graphql | through-router | PASS | live tx digest |
transactionEffects |
graphql | through-router | PASS | live tx digest, status=SUCCESS |
transactions |
graphql | through-router | PASS | |
type |
graphql | through-router | PASS | 0x2::sui::SUI |
multiGetAddresses |
graphql | through-router | PASS | |
multiGetBalances |
graphql | through-router | PASS | |
multiGetCheckpoints |
graphql | through-router | PASS | |
multiGetEpochs |
graphql | through-router | PASS | |
multiGetObjects |
graphql | through-router | PASS | |
multiGetPackages |
graphql | through-router | PASS | |
multiGetTransactions |
graphql | through-router | PASS | |
multiGetTransactionEffects |
graphql | through-router | PASS | |
multiGetTypes |
graphql | through-router | PASS | |
multiGetDerivedObjects |
graphql | through-router | PASS-existence | per-item BAD_USER_INPUT ("Literal error") on a non-Move-literal dynamic-field name — schema-valid, server-dispatched |
multiGetDynamicFields |
graphql | through-router | PASS-existence | same as above |
multiGetDynamicObjectFields |
graphql | through-router | PASS-existence | same as above |
simulateTransaction |
graphql | through-router | PASS-existence | BAD_USER_INPUT: Invalid JSON-encoded gRPC Transaction on minimal bcs |
verifySignature |
graphql | through-router | PASS-existence | BAD_USER_INPUT: Cannot parse signature on minimal signature |
executeTransaction |
graphql | — | SKIP | category.stateful=1, mutation — would broadcast a transaction |
Log-scan findings
Scanned the full probe window (docker logs sr_sui | tail -n +242) for warn|error|fatal|panic, excluding the documented benign set.
| Finding | Status |
|---|---|
15 matching lines, all tied to the 3 expected-refusal calls (Failed to SendRelay ×3, UniqueGuidResponseForError ×3, failed to getSupportedApi gRPC ×6, grpc in/out ×3) |
Expected behaviour under test, not a defect (per the PR-specific exception) |
| No other method-associated or free-standing warn/error/fatal/panic lines | — |
| No rate-limit (429) responses observed from either upstream during the whole run | pacing was never engaged; all methods probed unpaced |
Table intentionally otherwise empty — clean run.
Interface coverage
| Interface | Status | Evidence |
|---|---|---|
grpc |
Probed (28/28 apis: 24 through-router/direct PASS or PASS-existence, 3 PASS expected-refusal, 1 SKIP stateful) | this report |
graphql |
Probed (37/37 apis: 36 through-router PASS/PASS-existence, 1 SKIP stateful) | this report |
jsonrpc |
NOT_TESTABLE | Carried forward from Phase 7.5: Sui's public JSON-RPC was deprecated fleet-wide (July 2026, code removal Oct 2026). Phase 7.5 searched Mysten fullnodes, BlockVision, PublicNode, Ankr, BlastAPI, GetBlock, Tatum, Inodra — every one returns an explicit deprecation error or demands a paid key. No jsonrpc listener was booted and no jsonrpc methods were probed in this phase. |
Testnet verification pass (Step 7)
- Config:
/tmp/sr_sui_testnet.yml,chain-id: SUITon endpoints and bothdirect-rpcblocks, upstreamsgrpcs://fullnode.testnet.sui.io:443/https://graphql.testnet.sui.io/graphql, published on3460/3461/7879. - Boot: clean, no fatal lines, grpc listener up within 1 poll iteration.
- PARSE_BLOCKNUM: OK —
rpc_endpoint_latest_block{grpc}=4.08232984e+08,{graphql}=4.08232982e+08, both with nonzerofetch_latest_successcounters and growing over the run. - PARSE_BLOCK_BY_NUM: NOT_EXERCISED (same metric/log absence as mainnet).
chain-idverification (SUITexpected_value = 69WiPg3DAQiwdxfncX6wYQ2siKwAe6L9BZthQea3JNMD): OK on both grpc and graphql providers —"[+] verified successfully"with matchingrawData.- No parse-failure signatures, no verify failures.
- Inheritance of the switch-off: confirmed by direct through-router call, not spec-graph inference alone —
ListCheckpoints/ListEvents/ListTransactionscalled againstlocalhost:3460(SUIT) all returned the identicalapi is disabled/Code: Unknownrefusal seen on mainnet. This is strong evidence becauseSUIT'sapi_collections[].apisarrays are empty (confirmed viajq) —SUITcarries no api definitions of its own and resolves every method, including the disabled ones, purely throughimports: ["SUI"].
TESTNET_VERIFY: OK
Empirical block time (Step 8)
Measured via direct gRPC LedgerService/GetCheckpoint timestamp delta over 100 checkpoints (GetServiceInfo.checkpointHeight as latest).
| Network | Spec average_block_time |
Empirical | Deviation | Flag |
|---|---|---|---|---|
| SUI (mainnet) | 222 ms | (346850769 − 346850669 checkpoints) → 24177 ms / 100 = 241.8 ms | +8.9% | within 20% — no mismatch |
| SUIT (testnet) | 222 ms (own value, same as SUI; confirmed via jq, not merely inherited) |
(408233048 − 408232948 checkpoints) → 21372 ms / 100 = 213.7 ms | −3.7% | within 20% — no mismatch |
|
Phase 8 — smart-router boot + probe (CONCORDIUM / CONCORDIUMT)
Why PARSE is PARTIAL and VERIFY is FAIL — and why neither is a defect in this PR. The public Concordium gRPC endpoints do not expose server reflection for The four claims this PR makes — all CONFIRMED:
One finding beyond the PR's scope, flagged for review: about 20 further spec-enabled grpc methods are also genuine server streams per the proto ( The one FAIL ( Concordium Smart-Router Method Probe Report
Important environment finding (read before the tables below)The public mainnet and testnet Concordium gRPC endpoints do not expose Crucially, this limitation does not block the actual thing this phase needs to confirm: the disabled-method check happens in Step 3.5 — Parse-directive & verification runtime check
No Verification outcomes (grpc-only; rest collections carry no verifications):
Addon & extension coverage
Per-method tableThe five PR-disabled stream methods are listed first.
Additional finding beyond the PR's stated scope (flagged, not a required claim)The spec leaves roughly 20 other grpc methods Log-scan findingsAll non-benign WARN/ERROR lines in the probe window are attributable to the single root cause above (grpc provider repeatedly failing Positive evidence (excluded from findings per the task's exception for this PR): 30 occurrences of Testnet verification pass (Step 7)
Empirical block time (Step 8)
No |
|
Phase 9 — parallel reviewers (3 per spec file, independent contexts) Six reviewers ran
On the PR's own diff: 6 of 6 reviewers found it correct and ready to ship as-is. Every finding below is about pre-existing state in Merged gaps (deduplicated)1. CRITICAL — 2. CRITICAL / MEDIUM — 3. MEDIUM — the three gRPC 4. MEDIUM / MINOR — 5. MEDIUM — Items the reviewers checked and explicitly did not flag
Static gates (re-run on both files, with
|
|
Phase 10 — synthesize gaps + fix pass (+ 10b smoke re-probe) What was changedOne edit, in
(gap: MEDIUM, "gRPC subscription methods priced at 20 CU against the catalog-wide 1000 CU convention" — raised by 3/3 sui reviewers)
What was deliberately NOT changed, and whyFour findings survived consolidation but were held out of the fix pass. Each is recorded here rather than silently dropped; all four are pre-existing on 1. CRITICAL — 2. CRITICAL/MEDIUM — Concordium 3. MEDIUM/MINOR — 4. MEDIUM — Disabled-API Justifications: no new disables this run, so nothing is added to the ledger. The eight already in the PR are evidenced by the official protos ( Phase 10a — static gates re-run after the fix
Phase 10b — smoke re-probe:
|
| method | client status | dispatch path |
|---|---|---|
GetAccountList, GetAncestors, GetBakerList, GetBlockItems, DryRun |
Unknown: …failed to getSupportedApi gRPC ErrMsg: api is disabled |
refused before dispatch — outcome: "rejected_before_dispatch", method: "", attempts: [], and no VALIDATING PROVIDERS line for any of their GUIDs |
GetBlockInfo (enabled control) |
Unknown: {"Error":"No pairings available."} |
reached provider selection — VALIDATING PROVIDERS fires, error_code: PROTOCOL_NO_PROVIDERS, stop_reason: AllProvidersExhausted |
Across the whole log VALIDATING PROVIDERS fires for exactly two GUIDs: the startup verification pass and the GetBlockInfo call. The five disabled methods never reach it. REFUSAL_CONFIRMED: YES on the image this PR targets — the two failure modes are textually and structurally distinct, and the earlier api not supported line that fired for both turned out not to be a disabled-specific signal in that other build.
|
Disabled-API Justifications Positive-evidence ledger for every
Verified independently during this pipeline run (not taken from the PR body): the Sui rows were read from the live mainnet fullnode's own gRPC server reflection, and the Concordium rows from the upstream proto fetched this run. The control cases confirm the shapes discriminate rather than matching everything — No disables were added by this run's Phase 10 fix pass, so nothing is appended below these eight. |
|
Phase 11 — final reviewer verdict:
The mechanical rule is unambiguous — any remaining CRITICAL or MEDIUM means CHANGES REQUESTED, and I am not going to round that up. But the verdict needs its context to be useful: both final reviewers independently judged this PR's own diff correct, verified and ready to merge as written. Every finding below is a pre-existing defect in Disable-justification audit — clean on both filesEvery Remaining findings — all pre-existingsui.json — CRITICAL: sui.json — CRITICAL: sui.json — MEDIUM: GraphQL concordium.json — CRITICAL: concordium.json — MEDIUM: Evaluated and found NOT to be defectsThe grpc Scripted checks on both files: Recommended dispositionMerge #210 on its own merits, then take the follow-ups separately: |
|
Phase 12 — closing summary checklist Resumable pipeline run, Phases 8–11 only. Phases 1–7 did not run this invocation (the spec was already committed on the branch); context was reconstructed from File Validation
Configuration Verification
Interface coverage
Documentation (out of skill scope — manual reminder)
Testnet vs Mainnet
Governance Prep (out of skill scope — manual reminder)
Decisions this unattended run made on its own
Things worth knowing about the harness itself
Run stats — this pipeline run only (Phases 8–11)Phases 1–7 ran in a separate create_spec workflow run; their time and tokens live there. The true end-to-end total is the two runs added together — the figures above are not a 1–11 grand total. The working tree holds one uncommitted edit ( |
Auto-committed by spec_pipeline.yml after the Phase-10 fix pass. Run: https://github.com/Magma-Devs/lava-specs/actions/runs/44479550475
|
📦 Committed pipeline fixes to |
What
Eight gRPC methods answer with a stream of replies, and the specs did not mark them as subscriptions. They are switched off (
"enabled": false):sui.rpc.v2.LedgerService/ListCheckpointssui.rpc.v2.LedgerService/ListTransactionssui.rpc.v2.LedgerService/ListEventsconcordium.v2.Queries/GetAccountListconcordium.v2.Queries/GetAncestorsconcordium.v2.Queries/GetBakerListconcordium.v2.Queries/GetBlockItemsconcordium.v2.Queries/DryRunWhy
The router serves a gRPC server stream only when the spec names it as a subscription. It sent these as single-reply calls:
Switched off, the call is refused when it is parsed, before any provider is asked. The subscribe methods (
SubscribeCheckpointsand the rest) stay served. Serving the list methods properly needs a stream path of its own: marking them as subscriptions would share one stream between callers and re-send the request after an error, so a caller could miss items or get them twice.Tested
enabledvalues; the pipeline's commit is below.keeper.GetSpecFromLocalDirs) and parsed each method with the gRPC chain parser. All eight are refused ("api is disabled") in all five specs: SUIT and SUID take the switch-off from SUI, and CONCORDIUMT from CONCORDIUM.GetCheckpoint,SubscribeCheckpointsandGetConsensusInfostill parse. On this repo's main, all eight parse in all five.fullnode.mainnet.sui.io:443:ListCheckpointsis refused without a provider being asked, andGetServiceInfois served.check_disabled_count.shon each file reports exactly these methods;check_chain_identity.shpasses.What the caller gets
On router main, a switched-off gRPC method comes back as
UNKNOWN. The router change that makes itUNIMPLEMENTEDis in review separately (smart-router, the gRPC call-type refusal). Two spec files change, so the disabled-count guard runs report-only.The pipeline's commit
The spec pipeline's fix pass committed
7594ebe5: the three SuiSubscriptionService/Subscribe*methods go from 20 to 1000 compute units. Every other subscribe method in the repo is priced at 1000, and its smoke re-probe still received messages on all three through the router. I kept it.It also flagged two items it did not change, both already on main. Neither is in this PR:
GetBlocksandGetFinalizedBlocksare server streams that never end, and they are still enabled. It could not check them through the router, because the public Concordium nodes serve no reflection.Jira ticket: MAG-5178
🤖 Generated with Claude Code