Skip to content

ci(deploy): tag the task definitions the deploy registers - #68

Merged
nimrod-teich merged 1 commit into
mainfrom
mag-5145
Nov 11, 2026
Merged

nimrod-teich merged 1 commit into
mainfrom
mag-5145

Conversation

@nimrod-teich

Copy link
Copy Markdown
Contributor

Jira ticket: MAG-5145

Summary

  • Both register-task-definition calls in deploy.yml (api, web) pass --tags ManagedBy=github-actions, Repository=$GITHUB_REPOSITORY, Workflow=.github/workflows/deploy.yml. Each revision CI registers then says where it came from.
  • Why: in AWS account 811430801429 the rule is that a resource with no ManagedBy tag was made by hand. The existing CI revisions were backfilled with the same three tags on 2026-11-11. Without this change, every deploy adds two untagged ones again.
  • Merge only after Magma-Devs/devops#54 is applied. ECS checks ecs:TagResource for tags passed on create, and the deploy role gets that grant from fix(health-probe): bound gRPC clientPool to stop memory leak #54. Merged earlier, the next deploy would fail on the register call.
  • The workflow is workflow_dispatch only, so merging deploys nothing.

Test plan

  • actionlint .github/workflows/deploy.yml: no new findings. The two SC2086 notes are on main already.
  • The CLI tag shorthand is the form used to backfill the 203 existing revisions with aws ecs tag-resource on 2026-11-11.
  • After merge: the next deploy.yml run registers revisions with ManagedBy=github-actions (check with aws ecs list-tags-for-resource).

Each revision CI registers now carries ManagedBy=github-actions, Repository and Workflow, so in AWS an untagged revision means one registered by hand. Needs the ecs:TagResource grant from Magma-Devs/devops#54 applied first; the register call is denied without it.
@nimrod-teich
nimrod-teich merged commit 3e5207d into main Nov 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant