Repository navigation
ci(deploy): tag the task definitions the deploy registers - #68
Merged
Merged
Conversation
Each revision CI registers now carries ManagedBy=github-actions, Repository and Workflow, so in AWS an untagged revision means one registered by hand. Needs the ecs:TagResource grant from Magma-Devs/devops#54 applied first; the register call is denied without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: MAG-5145
Summary
register-task-definitioncalls indeploy.yml(api,web) pass--tags ManagedBy=github-actions, Repository=$GITHUB_REPOSITORY, Workflow=.github/workflows/deploy.yml. Each revision CI registers then says where it came from.ManagedBytag was made by hand. The existing CI revisions were backfilled with the same three tags on 2026-11-11. Without this change, every deploy adds two untagged ones again.ecs:TagResourcefor tags passed on create, and the deploy role gets that grant from fix(health-probe): bound gRPC clientPool to stop memory leak #54. Merged earlier, the next deploy would fail on the register call.workflow_dispatchonly, so merging deploys nothing.Test plan
actionlint .github/workflows/deploy.yml: no new findings. The two SC2086 notes are on main already.aws ecs tag-resourceon 2026-11-11.deploy.ymlrun registers revisions withManagedBy=github-actions(check withaws ecs list-tags-for-resource).