Repository navigation
fix(web): serve the footer's Lava icon from public/ - #65
Merged
Merged
Conversation
The footer loaded lava-icon.svg from the lava-fe-assets S3 bucket, which belongs to an AWS account that is being shut down. The same file, byte for byte, now ships in apps/web/public/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Closes MAG-4940
Jira ticket: MAG-4940
Summary
lava-icon.svgfrom thelava-fe-assetsS3 bucket. That bucket belongs to an AWS account that is being shut down.apps/web/public/lava-icon.svg, andFooter.tsxpoints at/lava-icon.svg.Screenshots
The footer on this branch (
next start). It looks the same as before; the icon now comes from the site itself.Test plan
pnpm install && pnpm -r build && pnpm typecheck: all pass.next start, open/. The footer icon loads from/lava-icon.svg(200,image/svg+xml), and nothing on the page requestslava-fe-assets.