Repository navigation
docs(api): a zero or negative lava-relay-timeout is ignored (MAG-3988) - #54
Merged
Merged
Conversation
Magma-Devs/smart-router#452 stops a negative lava-relay-timeout from crashing the router by ignoring it, the same way an unparseable value already was. Say so next to the "used verbatim" promise, which still holds for every positive value. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
AnnaR-prog
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: MAG-3988
Router change: Magma-Devs/smart-router#452. Merge after it.
One sentence in
docs/api/directives.md, "Override the per-attempt timeout": a zero or negativelava-relay-timeoutis ignored like an unparseable one, and the request keeps the router's own timeout. Before #452, a negative value crashed the router process. The "used verbatim, not clamped to--min-relay-timeout" promise is unchanged and still holds for every positive value.mkdocs build --strictpasses locally. It touches a different paragraph from #52 and #53.🤖 Generated with Claude Code