Replay gfan interface history - #4466
Draft
antonleykin wants to merge 37 commits into
Draft
Conversation
… Tropical years ago)
… and update documentation
Member
|
As I recall, This is an issue on legacy systems since gfan doesn't compile unless you have a relatively modern gcc (or even on modern systems with clang). What's the preferred path forward?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings the
Tropicalbranch's work ongfanInterface.m2(developedduring the 2026 Warwick workshop, building on 2023 workshop code) into
development. The full per-commit history is preserved: the changes arereplayed as 37 linear commits on top of
development, with no unrelated-historymerge or disconnected root.
Changes to gfanInterface
gfanTropicalPrevariety— reworked method with two new options:"matrixoutput" => Boolean— exposes gfan's--matrixoutputflag; eachhalf-open cone is returned as an ambient dimension plus three matrices
(nonstrict inequalities, equations, strict inequalities).
"halfopenrestrictions"— passes gfan's--halfopenrestrictions, lettingthe computation be restricted to a supplied list of half-open cones.
gfanParsePolyhedralFan.gfanPadicInitialIdealand wires up thegfan _padiccommand (code originally written in the 2023 workshopdevelopment branch).
gfan _mixedvolumehandling.MarkedPolynomialList— implemented==for marked polynomial lists.gfanTropicalPrevariety(including
"matrixoutput"and"halfopenrestrictions"examples), plusnumerous test fixes (homogeneity space, fan product, mixed volume).
Net change: +514 / −239 in
M2/Macaulay2/packages/gfanInterface.m2.Checklist (per the M2 PR guide)
developmentbranch (notstable).Keywords => {"Interfaces"}present in the package header.DebuggingModenot enabled innewPackage(defaults to false).=distributed-packageschange needed.Contributors
@antonleykin
Diane Maclagan (github id info lost in commits) @dmaclagan ?
@GabrielRiffoJ
@VictoriaSchleis