Skip to content

remove temporary fixes due to #3017 #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pzinn wants to merge 1 commit into
base: development
Choose a base branch
from
Open

remove temporary fixes due to #3017 #4457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion M2/Macaulay2/m2/matrix2.m2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ trimPID := M -> if M.?relations then (if M.?generators then trimPID image genera
(g,ch) := smithNormalForm(f, ChangeMatrix => {true, false});
isunit := r -> r != 0 and degree r === {0};
rows := select(min(rank source g,rank target g),i->isunit g_(i,i));
rows = rows | toList(rank target f..<rank target g); -- temporary fix for #3017
ch = submatrix'(ch,rows,);
p:=id_(target ch)//ch;
q:=generators M*p;
Expand Down
1 change: 0 additions & 1 deletion M2/Macaulay2/m2/modules2.m2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ addHook((minimalPresentation, Module), Strategy => "PID", (opts, M) -> (
isunit := r -> r != 0 and degree r === {0};
piv := select(pivots g,ij -> isunit g_ij);
rows := first \ piv;
rows = rows | toList(rank target f..<rank target g); -- temporary fix for #3017
cols := last \ piv;
(g,ch) = (submatrix'(g,rows,cols),submatrix'(ch,rows,));
(g,ch) = (p' g,p' ch);
Expand Down
Loading