docs(handouts): refresh handout E after the #1055 rebase - #115
Merged
Conversation
Complexity Monitoring ReportThreshold: 15 Excellent! No complexity violations found. |
The PR is rebased onto main (4b1da50), all 10 checks pass, and the review request is posted, so the first three suggested work items are done. Two corrections carried over. The sparse-reduction caveat understated the problem: mean/std raise IndexError and max raises a TypeError about ndmin, not just sum on keepdims, and all of them raise at graph-build time rather than at compute(). The dependency floors are attributed to upstream main instead of the PR, which touches no pyproject.toml. Also records that the PR was silently broken before the rebase: upstream #1131 rewrote the join helpers to call reset_index()/groupby() on obs, which is a Dataset2D for a lazily-read table. It now carries the fix and a regression test.
Tomatokeftes
force-pushed
the
docs/refresh-lazy-table-handout
branch
from
July 30, 2026 19:52
51909a4 to
87209aa
Compare
Complexity Monitoring ReportThreshold: 15 Excellent! No complexity violations found. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Docs only. Refreshes
handouts/upstream-lazy-table-pr.md(handout E) so it describesthe current state of upstream scverse/spatialdata PR #1055 rather than the state it was
in before the 2026-07-30 rebase. No code, no dependency changes.
Type of Change
Related Issues
None. Tracks upstream scverse/spatialdata#1055.
Changes Made
main(eb4fb3d), head4b1da50, 13 commitssquashed to 5, 5 ahead / 0 behind, all 10 CI checks passing, review request posted.
keeping the original reasoning visible rather than deleting it. Item 4 (raising
Thyra's
spatialdata/dask/ome-zarrceilings) is flagged as the only one stillopen, and as gated on a maintainer rather than on us.
#1131 rewrote the join helpers to call
reset_index()/groupby()directly ontable.obs, which is an xarrayDataset2Dfor a lazily-read table, sobounding_box_query,get_valuesand all fivejoin_spatialelement_tablemodesraised
AttributeError. Reproduced on the pre-rebase headbfd2b5f, so it waspre-existing rather than rebase-induced. The PR now carries the fix and a regression
test.
Two factual corrections:
sumfailing onkeepdims:meanandstdraiseIndexError,maxraises aTypeErroraboutndmin, and all of them raise while dask builds the graph rather than at.compute(). Confirmed on both dask 2026.7.1 / scipy 1.18.0 and dask 2026.1.1 /scipy 1.16.0.
dask>=2026.3.0/ome_zarr>=0.16.0/distributed>=2026.3.0floors areattributed to upstream
maininstead of to the PR, which touches nopyproject.tomlat all. The previous wording read as though the PR had raised them.
Testing
No code changed, so nothing to test beyond that. The claims about upstream state were
checked against the live PR (
gh pr view/gh pr checks) rather than from memory.Code Quality
Documentation
Performance Impact
Additional Notes
The handout is the only thing changing here; the earlier claim that no Thyra code needs
to change for the lazy path to work still holds, and is re-stated with the clarification
that it was verified against the pre-rebase head and concerns the on-disk format, which
the rebase did not touch.