Skip to content

test(cage,fdtables): add CONC-001..005 concurrency and isolation coverage #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shounak-Ghosh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(cage,fdtables): add CONC-001..005 concurrency and isolation coverage #1349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,29 @@ jobs:
# - name: Run Zizmor
# env:
# GH_TOKEN: ${{ github.token }}
# run: zizmor -v .github/workflows #Running with -v to show all passes, will halt if any fail
# run: zizmor -v .github/workflows #Running with -v to show all passes, will halt if any fail

rust-unit-tests:
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- uses: Swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1

# Deliberately no `rustup default` override here: this uses the
# toolchain pinned in rust-toolchain.toml, unlike the `lint` job above
# which pins an older nightly for clippy compatibility (see #242).
- name: Cage crate unit tests
run: cargo test --manifest-path src/cage/Cargo.toml -- --test-threads=1

# --test-threads=1 is mandatory: fdtables' tests share process-global
# state (FDTABLE / FDCOUNT / CLOSEHANDLERTABLE) and serialize on a
# hand-rolled TESTMUTEX that several tests take only after calling
# refresh(), which wipes that same state. This runs against the
# default `dashmaparray` feature only, which is what the rest of the
# build uses (see FDTABLES_IMPL in the top-level Makefile).
- name: fdtables crate unit tests
run: cargo test --manifest-path src/fdtables/Cargo.toml -- --test-threads=1
3 changes: 3 additions & 0 deletions skip_test_cases.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@ memory_tests/deterministic/tcache_test.c
process_tests/deterministic/fork_max_cages.c
ci/deterministic/ci_intentional_failure_tmp.c
memory_tests/deterministic/mmap_null_address_mapping.c
process_tests/deterministic/conc_004_dup_close_fork_refcounts.c
process_tests/deterministic/conc_005_fd_exhaustion_isolation.c
process_tests/deterministic/conc_005_memory_pressure_isolation.c
Loading