test(iso1-memory): add cross cage memory isolation tests - #1313
Open
lionne99 wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@Yaxuan-w @vidyalakshmir for review |
Member
|
@Uk-jake Do you have any idea on why the results doesn't being published as comment here? Thanks |
Contributor
Not sure, but it might be because it's a PR from a fork. I'll take a look |
Yaxuan-w
requested changes
Aug 10, 2026
| -1, 0); | ||
|
|
||
| assert(invalid != MAP_FAILED); | ||
| assert(munmap(invalid, REGION_SIZE) == 0); |
Member
There was a problem hiding this comment.
maybe using sth like:
unsigned char *invalid = mmap(NULL, REGION_SIZE, PROT_NONE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);| (volatile unsigned char *)malloc(64); | ||
|
|
||
| if (ptr == NULL) | ||
| return 1; |
Member
There was a problem hiding this comment.
The setup failure should return 0 to indicate this error is not intended
| free((void *)ptr); | ||
|
|
||
| return 0; | ||
| } No newline at end of file |
|
|
||
| printf("cross_cage_syscall_efault test: PASS\n"); | ||
| return 0; | ||
| } No newline at end of file |
|
|
||
| printf("cross_cage_fork_no_leak test: PASS\n"); | ||
| return 0; | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
Seems we can merge this test into invalid_access_direct.c
Yaxuan-w
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests covering cross-cage memory isolation ISO-001.
Tests added:
cross_cage_fork_no_leak.c
cross_cage_syscall_efault.c
cross_cage_wild_pointer.c
All tests were tested locally.