Expose explicit fused attention selection in the C API - #9
Draft
Gajesh2007 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose the existing C++
force_fusedattention option through a new C entry point,mlx_fast_scaled_dot_product_attention_with_force_fused. Callers that must bound temporary allocation can request a fused kernel and receive an error for unsupported shapes instead of a composed score tensor.The existing C entry point and ABI remain available and delegate with
force_fused=false.Before
After
Validation
Five Swift/C API tests passed on M4 Max: explicit-false equality with the existing entry point, fused pitched views/masks/sinks against a dense reference, GQA8, D512 refusal, and a no-score-materialization allocation check. The wide-head cases use the companion MLX tile correction; the Swift package pins both dependencies together.
Used by the separately reserved prefill candidate in Layr-Labs/mlx-swift-lm#142 and Layr-Labs/d-inference#860.