Support for mutual inductives - #1053
Closed
Janno wants to merge 27 commits into
Closed
Conversation
Those two thing are not the same.
Merged
Contributor
|
Thanks, I started to review some code but the current structure is hard to review/merge. I think it would help to have all changes about .ml files and files in elpi/ and tests/ to be part of a first PR. Then have all changes about derive/eq to be in a followup commit in another PR. And so on. This way I can merge things incrementally, and add tests on each of these. Can you squash then separate the changes in this way? |
Contributor
|
Btw is this the same code as SkyLabsAI#2? |
Contributor
Author
Yes, this is the same code rebased on master (instead of our own vendored snapshot).
Yes, I'll try to get that done ASAP. |
1 task
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.