Conversation
- Custom OpenAI-compatible providers via settings.json customProviders - ModelRegistry.apply_custom_providers for dynamic provider registration - Model picker: grouped providers, connected filter, Tab nav, favorites - Provider picker dynamically lists custom providers - Keybinding entries for picker keys (f, *, a) in keybindings.rs - is_provider_connected helper for connection status checks - open_model_picker_all_providers for cross-provider model browsing - Custom provider tests Rebased from Kuberwastaken#386. Excludes Cursor ACP (separate PR) and bang command payload.
alecuba16
force-pushed
the
pr386-providers
branch
from
September 3, 2026 11:16
f7c2440 to
d3ac4f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased version of #386 — custom providers and model picker overhaul. Carries the full review-response rework addressing all points from the #386 review threads.
Changes
settings.jsoncustomProviders; resolved once intoConfig.custom_providersat load time (no per-request/per-frameSettings::load_sync()).ModelEntry.provider_id, sofree/autoworks), default selection.keybindings.rs: newKeyContext::ModelPickerwith 13 default bindings (prevModel...toggleFavorite,toggleShowAllProviders). Typing "claude"/"haiku"/"flash" in the filter works.tracing::warn!.requestTimeoutSecsapplied viaOpenAiCompatProvider::with_request_timeout().resolve_api_keyusessubstitute_env_varsso{env:FOO}and embeddedBearerpatterns work; empty-after-substitution yieldsNone(picker no longer marks unset providers connected).contextWindowdefaults to 128k with a warning when unset.~/.claurst/settings.json, no internal gateway ids in fixtures.Rebase notes
app.rschanges to newapp/modules (keys.rs,providers.rs,mod.rs).keybindings.rsandregistry.rs.Validation
cargo check --workspace— cleancargo clippy --workspace --all-targets -- -D warnings— cleancargo test --workspace— 678 passed, 1 pre-existing failure (settings_screen, fails on main too)Supersedes #386.