Skip to content

Fix usage of vkCreateDebugUtilsMessengerEXT/vk::Instance::createDebugUtilsMessengerEXT. - #1526

Open
asuessenbach wants to merge 3 commits into
KhronosGroup:mainfrom
asuessenbach:debug_callbacks
Open

Fix usage of vkCreateDebugUtilsMessengerEXT/vk::Instance::createDebugUtilsMessengerEXT.#1526
asuessenbach wants to merge 3 commits into
KhronosGroup:mainfrom
asuessenbach:debug_callbacks

Conversation

@asuessenbach

@asuessenbach asuessenbach commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Description

Using VkDebugUtilsMessengerCreateInfoEXT needs special consideration, depending on where it is used.

  • VkDebugUtilsMessengerCreateInfoEXT is specified to extend VkInstanceCreateInfo, and multiple instances of it in that extension chain are allowed. That is, with multiple VkDebugUtilsMessengerCreateInfoEXTs in that chain, multiple callbacks are created on instance creation, but just for a very short period of time.
  • VkDebugUtilsMessengerCreateInfoEXT is not specified to extend itself! That is, with multiple instances of it in the pNext-chain for vkCreateDebugUtilsMessengerEXT, just the very first VkDebugUtilsMessengerCreateInfoEXT in that chain is used to create a callback. Actually, I would have expected that the validation layers would fire a warning with such a usage.

The sample shader_debugprintf used an additional VkDebugUtilsMessengerCreateInfoEXT for both, Instance and DebugUtilsMessenger creation. Now, a separate local DebugUtilsMessenger is created to have both callbacks, the one from the sample and the one from the framework, alive.

Build tested on Win11 with VS2022. Run tested on Win11 with NVidia GPU.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@asuessenbach
asuessenbach requested a review from a team April 23, 2026 15:45
Comment thread samples/extensions/shader_debugprintf/shader_debugprintf.cpp Outdated
Comment thread framework/vulkan_sample.h
Comment thread samples/extensions/shader_debugprintf/shader_debugprintf.cpp
@asuessenbach asuessenbach changed the title Use StructureChainBuilder to create the debug callbacks. Fix usage of vkCreateDebugUtilsMessengerEXT/vk::Instance::createDebugUtilsMessengerEXT. Jul 7, 2026
@asuessenbach

Copy link
Copy Markdown
Contributor Author

Note: I still had to manually undo some formatting so that the “clang-format” CI step could be completed successfully.

@asuessenbach
asuessenbach requested review from a team and SaschaWillems July 14, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants