Repository navigation
use more precise structural inspection of types for ambiguity exclusions #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,11 @@ include("preamble.jl") | |
| if broken | ||
| @test_broken num_ambiguities_ == num_ambiguities | ||
| else | ||
| if num_ambiguities_ != num_ambiguities | ||
| @show exclude | ||
| println(strout) | ||
| println(strerr) | ||
| end | ||
| @test num_ambiguities_ == num_ambiguities | ||
| end | ||
| end | ||
|
|
@@ -44,7 +49,7 @@ include("preamble.jl") | |
| check_testcase([PkgWithAmbiguities.ConcreteType], total - num_ambs_ConcreteType) | ||
|
|
||
| # exclude abstract supertype without callables and constructors | ||
| check_testcase([PkgWithAmbiguities.AbstractType], total) | ||
| check_testcase([PkgWithAmbiguities.AbstractType], total - num_ambs_SingletonType - num_ambs_ConcreteType) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems like an unwanted behavioral change. Note, however, that with the current behavior, excluding Since we already have a breaking change in master, it would be fine to slightly change the semantics of exclusion here, but that would need some good explanation of the new semantics in the docstring of
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay, I've switched it back to doing only structural inspection instead of the subtyping queries and just simplified them to stay in the type domain where the comparisons can be made more reliable. It is less powerful (since it cannot realize that |
||
|
|
||
| # for ambiguities between abstract and concrete type callables, only one needs to be excluded | ||
| check_testcase( | ||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this related to the rest of the changes in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just debugging for the relevant tests if they change reporting