Repository navigation
Add typemin in math.jl - #208
Merged
Merged
Conversation
Member
|
Thanks! Can you rebase on main and add a test? |
mangelmauriz
force-pushed
the
patch-1
branch
from
September 20, 2026 10:17
9168eb8 to
05ca5f4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 15 15
Lines 786 787 +1
=======================================
+ Hits 752 753 +1
Misses 34 34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
Hi @giordano, I believe I’ve rebased my branch onto main and added the requested test. But the |
Member
|
Yeah, that's unrelated to your change, I'm looking into it |
mangelmauriz
force-pushed
the
patch-1
branch
from
September 20, 2026 13:17
0042a9e to
cc674ae
Compare
mangelmauriz
marked this pull request as draft
September 21, 2026 11:59
mangelmauriz
marked this pull request as ready for review
September 21, 2026 11:59
Contributor
Author
|
Hi @giordano , I think it's ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, calling
typeminwith aMeasurementas an argument throws an error. This appears to be an oversight, sincetypemaxandfloatminare already defined forMeasurement.Measurements.jl/src/math.jl
Lines 728 to 731 in a70d82c
Defining
typeminalso allowsMeasurementvalues to be used withAlgebraOfGraphics.jl.