ui: stop update text overflowing the channel tiles and the status table - #1577
Merged
Conversation
The pending-update badge read `Update: → 1.12.7+0.aarch64.apple.darwin14`. egui's proportional font is Ubuntu-Light, which has no arrows, so the `→` rendered as a tofu box; the bundled `Hack` face is the only one that covers U+2192 and it is not in the proportional fallback chain. Append it, which also fixes the arrows in `Linked → …`, `Alias → …` and the override and link status messages. The badge itself was far too long for a 168pt tile and sat on an untruncated label, so it wrapped and spilled out over the neighbouring tile. It now shows the target version with the `+<build>.<platform>` tag dropped when it matches what is installed, and carries the full version in a tooltip. Both the update and version labels are truncated in the tile and the list view, so no string length can spill again; the list view needs it independently because `egui_extras` columns do not clip by default. Stack the tile buttons up from the bottom with `Layout::bottom_up` rather than positioning them by arithmetic against `min_rect`, which the tile's own `set_min_size` had already made a no-op. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
With updates pending, `juliaup status` rendered a 140 column table, which wraps and is unreadable in an 80 column terminal. The update column repeated the platform tag that the version column already showed, and the pull request URL added in #1561 made the version column 61 characters wide. The update column now shows just the target version, with the build tag dropped when it matches what is installed. If the table still does not fit, the version column also drops the build tag and shortens the pull request URL to `(#62359)`. Terminals wide enough for the full table keep it, and output that is not going to a terminal is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The tile view gated the whole secondary action row on `!row.is_default`, so the default channel showed an `Update:` badge with no button to act on it. Suppressing `Default` and `Remove` there is right, since the channel is already the default and cannot be removed, but `Update` was caught by the same condition. Gate each button on its own, as the list view already does, and size them by how many are actually shown. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codex review. `strip_build_tag`'s doc repeated what `format_version`'s already said, and the rest ran two or three lines longer than they needed to. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need visual regression tests..
Master
PR
Claude:
The GUI's channel tiles showed a pending update as
Update: → 1.12.7+0.aarch64.apple.darwin14. The→was a tofu box: egui's proportional font is Ubuntu-Light, which has no arrows, and the bundledHackface that covers U+2192 is not in the proportional chain. The text was also far too wide for a 168pt tile and sat on an untruncated label, so it wrapped and spilled over the neighbouring tile.Hackis now appended to the proportional chain, which also fixesLinked → …,Alias → …and the override and link status messages. The badge readsUpdate: 1.12.7, with the+<build>.<platform>tag dropped when it matches what is installed and the full version in a tooltip. Update and version labels are truncated in both views; the list view needed that independently, becauseegui_extrascolumns do not clip by default. Tile buttons now stack up from the bottom withLayout::bottom_uprather than by arithmetic againstmin_rect, which the tile's ownset_min_sizehad already made a no-op.The secondary action row was gated as a whole on
!row.is_default, so the default channel got anUpdate:badge and no button to act on it.DefaultandRemovebelong behind that condition,Updatedoes not; each is now gated on its own, as the list view already did.juliaup statushad the same problem in a terminal, reaching 140 columns with updates pending. The update column now says1.12.7rather thanUpdate to 1.12.7+0.aarch64.apple.darwin14 available, and if the table still would not fit, the version column drops the build tag and shortens the pull request URL from #1561 to(#62359). Wide terminals keep both, and output that is not going to a terminal is unchanged.This overlaps #1558, which drops build metadata from
listandstatusunconditionally rather than only when the table would not fit.