Skip to content

Fix concurrent add dropping downloaded version - #1573

Merged
IanButterworth merged 1 commit into
JuliaLang:mainfrom
KristofferC:codex/fix-add-channel-race
Aug 17, 2026
Merged

Fix concurrent add dropping downloaded version#1573
IanButterworth merged 1 commit into
JuliaLang:mainfrom
KristofferC:codex/fix-add-channel-race

Conversation

@KristofferC

@KristofferC KristofferC commented Aug 17, 2026

Copy link
Copy Markdown
Member

This has gotten little review of my own but putting it up at @IanButterworth request.

Summary

  • make the post-download juliaup add conflict check version-aware
  • commit and register the downloaded version when a concurrent system channel points at a different version, then move the channel to the requested version
  • discard true duplicate downloads while preserving concurrent linked, direct-download, and alias channel name claims
  • add regression tests for each conflict policy and document the updated locking flow

This fixes the race introduced by #1517 where add could print Installing ... followed by already installed, delete the completed temporary install, and leave the channel on an older version.

@IanButterworth IanButterworth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@IanButterworth
IanButterworth merged commit d686de8 into JuliaLang:main Aug 17, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants