Wrap more into interactive startup updates in julialauncher - #1535
Open
xgdgsc wants to merge 3 commits into
Open
Wrap more into interactive startup updates in julialauncher#1535xgdgsc wants to merge 3 commits into
xgdgsc wants to merge 3 commits into
Conversation
- Introduced a new function `run_startup_updates` to handle both version database updates and self-updates when the launcher is invoked in interactive mode. - Modified the process for forking and executing the Julia process to ensure updates are only triggered in interactive sessions. - Added tests to verify that self-updates are correctly triggered in interactive mode and not in non-interactive invocations (e.g., `julia -e`). - Enhanced the test suite to simulate interactive terminal sessions for more accurate testing of the launcher behavior.
- Simplified the command construction for executing Julia in interactive mode by removing unnecessary conditional branching.
- Ensured that the command is consistently built using `Command::new("script")` for both macOS and other platforms.
- Improved readability and maintainability of the code by consolidating command argument handling.
- Simplified the logic for determining if the Julia launcher is running in interactive mode by clarifying the role of TTY access and the `-i` flag. - Updated comments for better clarity on the conditions that define interactivity. - Adjusted the `run_julia_interactive` test to directly invoke the Julia symlink without relying on `script`, improving cross-platform consistency and reliability.
Collaborator
|
I don't agree with this approach. If version db and self-updates are configured to happen, then it should be triggered regardless of whether the launcher is started in interactive mode or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_startup_updatesto handle both version database updates and self-updates when the launcher is invoked in interactive mode.julia -e).fix #1519