Irregular chunks - #326
Open
meggart wants to merge 45 commits into
Open
Conversation
- Move src/ to lib/ZarrCore/src/ - Move deps, establish workspace, etc. - Change some names around to make Zarr.jl references into ZarrCore.jl references
# Conflicts: # CHANGELOG.md # Project.toml
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The user facing interface is public in Zarr while the developer facing interface is only public in ZarrCore.
# Conflicts: # CHANGELOG.md # Project.toml # lib/ZarrCore/src/ZGroup.jl # test/arraycache.jl # test/storage.jl
This is necessary because in 1.10 the names function behaves differently and the public names are not imported into Zarr.
Coverage Report for CI Build 32493520649Coverage remained the same at 93.151%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Member
|
this PR should target now |
Closed
Collaborator
Author
|
I just switched the base branch. Now there is tons of merge conflicts. I can not solve this today... |
Member
|
probably is easier to start over from main, and just copy/paste/commit the files that had been changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an almost complete attempt to add irregular chunks to the V3 metadata. Only a few tests need to be fixed and some new tests added.