Prefix custom structures with _ to hide them - #104
Conversation
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=======================================
Coverage 88.19% 88.19%
=======================================
Files 11 11
Lines 1330 1330
=======================================
Hits 1173 1173
Misses 157 157
Continue to review full report at Codecov.
|
|
I thought we already have LorentzVector for test coverage so actually, if you don't need them to be inside UnROOT, feel free to delete them haha. Which will increase our coverage %! |
|
I'd rather add more tests 😆 I promise I'll do 😉 |
|
I mean they could be in the test for sure, I'm saying if you don't need experiment-specific structs live inside UnROOT.jl. I'm just unsure how much you've factored out and how much you still rely on what's inside UnROOT.jl for actual work, so we didn't touch it. |
|
I think I have factored out everything, so they are really only there for tests. I just realised there is this |
Since the custom stuff is mostly for test coverage, it makes sense to hide it from the public API. Btw. it also collides with downstream code since the structs are usually defined there and otherwise there is a clash, see #95 (comment)