Skip to content

Fix default constraints in Manopt.jl (nothing -> missing in v0.6.4) - #100

Merged
JoshuaLampert merged 4 commits into
mainfrom
fix-manopt-constrained-objective-default
Aug 25, 2026
Merged

Fix default constraints in Manopt.jl (nothing -> missing in v0.6.4)#100
JoshuaLampert merged 4 commits into
mainfrom
fix-manopt-constrained-objective-default

Conversation

@JoshuaLampert

Copy link
Copy Markdown
Owner

In JuliaManifolds/Manopt.jl#630 the default for g, grad_g, h, and grad_h changed from nothing to missing, i.e., explicitly passing nothing does not work anymore with Manopt.jl >=v0.6.4. Since it is the default anyway, simply removing the kwargs should fix it on both >=v0.6.4 and <v0.6.4.

@JoshuaLampert

Copy link
Copy Markdown
Owner Author

There were some issues with Manopt.jl v0.6.4 and v0.6.5, which should hopefully be fixed with Manopt.jl v0.6.6.

@JoshuaLampert

JoshuaLampert commented Aug 25, 2026

Copy link
Copy Markdown
Owner Author

Ok, now the registry server is back and we get Manopt.jl v0.6.6., but there are new failures. This time they seem to come from trixi-framework/TrixiBase.jl#76.

Comment thread test/test_aqua.jl Outdated
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.20%. Comparing base (cd1809d) to head (be4f2e9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files          26       26           
  Lines        1389     1389           
=======================================
  Hits         1364     1364           
  Misses         25       25           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoshuaLampert
JoshuaLampert merged commit 6407257 into main Aug 25, 2026
12 checks passed
@JoshuaLampert
JoshuaLampert deleted the fix-manopt-constrained-objective-default branch August 25, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant