Fix default constraints in Manopt.jl (nothing -> missing in v0.6.4) - #100
Merged
Conversation
Owner
Author
|
There were some issues with Manopt.jl v0.6.4 and v0.6.5, which should hopefully be fixed with Manopt.jl v0.6.6. |
Owner
Author
|
Ok, now the registry server is back and we get Manopt.jl v0.6.6., but there are new failures. This time they seem to come from trixi-framework/TrixiBase.jl#76. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 98.20% 98.20%
=======================================
Files 26 26
Lines 1389 1389
=======================================
Hits 1364 1364
Misses 25 25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In JuliaManifolds/Manopt.jl#630 the default for
g,grad_g,h, andgrad_hchanged fromnothingtomissing, i.e., explicitly passingnothingdoes not work anymore with Manopt.jl >=v0.6.4. Since it is the default anyway, simply removing the kwargs should fix it on both >=v0.6.4 and <v0.6.4.